Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider using a test framework #76

Open
FaragElsayed2 opened this issue May 2, 2023 · 0 comments
Open

consider using a test framework #76

FaragElsayed2 opened this issue May 2, 2023 · 0 comments

Comments

@FaragElsayed2
Copy link
Collaborator

FaragElsayed2 commented May 2, 2023

Expected Behavior

Tests should be using python testing best practices.

One popular framework is pytest: https://docs.pytest.org/en/7.2.x/ as it comes with:

Actual Behavior

Tests uses monolytics python scripts with manual exit() invocation, see https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/drc/testing/run_regression.py#L243

Refer to google/globalfoundries-pdk-libs-gf180mcu_fd_pr#79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant