-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multipart uploads #26
Comments
This seems reasonable to me (another endpoint to support). But, I'm not sure I understand this part:
An |
@tbpg I'm basing my intuition off of this medium post. The gist would be that if we want multipart support, we need some in-memory buffer to pass to Admittedly, I did not attempt to replicate the findings of this post, so it could be possible that Go has improved buffering for large requests like this, but I'm not sure. |
Gotcha. That seems reasonable to me. I think we'd have to play with what the exact API is for the |
Yeah, point definitely taken on trying to be implementation/caller-agnostic. That said, the docs for this particular endpoint suggest that it is specifically for use with multipart uploads. |
Hello |
I'm very open to a PR here. Warning, we might need to modify the interface a little bit, keeping it as minimal as possible while enabling you to do what you need to do. |
Tika appears to support multipart file uploads via the endpoint
POST /tika/form
, as documented here.It would be great to add this support so that we could use the client for uploading large files without having to hold the buffer with all bytes in memory.
The text was updated successfully, but these errors were encountered: