Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using TMPDIR instead of current users home. #31

Open
qzaidi opened this issue Feb 11, 2017 · 5 comments
Open

Using TMPDIR instead of current users home. #31

qzaidi opened this issue Feb 11, 2017 · 5 comments

Comments

@qzaidi
Copy link

qzaidi commented Feb 11, 2017

It may be a better idea to use TMPDIR instead of current user's home directory for writing gops port files. The homedir may not be writable, while TMPDIR is. It also allows us to run gops binary with a different user than the app embedding the gops agent.

@rakyll
Copy link
Member

rakyll commented Mar 2, 2017

TMPDIR might be deleted, PID files shouldn't get lost. In the case of long-running processes, you don't want to end up seeing you cannot access to a problematic server because the PID file is gone.

We just merged a PR that allows you to use gops against an address, does that work for you better?
288e543

Maybe we should just silently ignore when we cannot write a PID file and expect user to target the address when they are using the command line tool.

@SvenDowideit
Copy link

I'm having a quick play adding gops to RancherOS, and so some of the go processes are in namespaced filesystems. I think at the moment, /run is common to most of the containers - so I'm wondering if we could add an agent Option GopsDir, and either softlink that into the user's .config, use a GOPSDIR env var, or something else way more clever :)

@zuoRambo
Copy link
Contributor

#60

@xaurx
Copy link
Contributor

xaurx commented May 19, 2023

it is still an issue if one tries to run inside k8s container with read only root file system.
if nobody objects I would simply ignore read-only file system and permission denied errors on mkdir/write of config. We have remote mode anyway.

opinion?

@inliquid
Copy link

@xaurx just got the same issue, k8s environment and read-only filesystem. Maybe give an option to not write to portfile at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants