magika_node missing from exports in package.json

[pixartist]

Currently this package is not usable in typescript via node as the node export is missing from the package.json

[pixartist]

ps: the labels were automatically added and I cant remove them

[grant-d]

+1

[invernizzi]

Extremely good point. It should be fixed now. Let me know if it looks good to you

[grant-d]

[edit - failed - see next comment]
Thanks @invernizzi
I can now import MagikaNode in the following style:

import { MagikaNode } from 'magika/dist/mjs/magika_node'

But the examples (even in the comments of file referenced above) show this style, which still doesn't work.
Not a problem per se, just FYI: (edit - see problem in next comment)

import { MagikaNode as Magika } from "magika"

[grant-d]

The 'path' import above works at lint-time, but fails at build-time due to ERR_PACKAGE_PATH_NOT_EXPORTED
The fix for that is to change the import to:

import { MagikaNode } from 'magika'

But that fails at lint-time (and maybe build-time) unless you change tsconfig to use node16 for module resolution, which breaks other package imports

[joshmcqueen]

Any resolution on this? I'm trying to import MagikaNode from a nextjs server side component. It works even though there is a linting error, however the app won't compile.

Module '"magika"' has no exported member 'MagikaNode'.ts(2305)

[ciekawy]

I found that to be able to import in CJS where I just cannot simpl migrate to ESM I need to modify magika package.json exports to (prepend both with ./) otherwise I am not able to import from 'magika/node':

    "exports": {
        "./node": {
            "import": "./dist/mjs/magika_node.js",
            "require": "./dist/cjs/magika_node.js"
        },
        "./default": {
            "import": "./dist/mjs/magika.js",
            "require": "./dist/cjs/magika.js"
        }
    },