We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OriginalFilename
VERSIONINFO
mozc_tip32.dll
mozc_tip64.dll
When building mozc_tip32.dll, its OriginalFilename element in VERSIONINFO resource is unexpectedly set to mozc_tip64.dll rather than mozc_tip32.dll.
While this should not have user observable behavior change in general, it would be safer to fix this before fully switching to Bazel from GYP.
Steps to reproduce the behavior:
Mozc64.msi
Original filename
mozc_tip32.dll.
mozc_tip64.dll.
e1b40ed
The text was updated successfully, but these errors were encountered:
Looks like this was also fixed by 4aad25e, where we started enabling CC toolchain resolution on Windows.
Here is the relevant code that wasn't working as expected until 4aad25e.
mozc/src/bazel/windows_sdk_rules.win32.template.bzl
Lines 166 to 171 in 6a64efa
Sorry, something went wrong.
yukawa
No branches or pull requests
Description
When building
mozc_tip32.dll
, itsOriginalFilename
element inVERSIONINFO
resource is unexpectedly set tomozc_tip64.dll
rather thanmozc_tip32.dll
.While this should not have user observable behavior change in general, it would be safer to fix this before fully switching to Bazel from GYP.
Steps to reproduce
Steps to reproduce the behavior:
Mozc64.msi
built with Bazel.mozc_tip32.dll
then click the "Details" tab.Original filename
section.Expected behavior
mozc_tip32.dll
.Actual behavior
mozc_tip64.dll
.Screenshots
Version or commit-id
e1b40ed
Environment
The text was updated successfully, but these errors were encountered: