Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candidate window may be misplaced when Per-Monitor DPI setting is enabled in Windows #832

Closed
yukawa opened this issue Oct 21, 2023 · 0 comments
Closed

Candidate window may be misplaced when Per-Monitor DPI setting is enabled in Windows #832

yukawa opened this issue Oct 21, 2023 · 0 comments

Comments

@yukawa
Copy link
Collaborator

yukawa commented Oct 21, 2023

Description

When Mozc is used under Per-Monitor DPI environment where each display has different effective DPI, Mozc's candidate window may not be shown at the expected location.

This is a sub task of the following effort.

Steps to reproduce

  1. Build and install Mozc into multi-display environment, where each display is configured to have different effective DPI
  2. Open a notepad in secondary display
  3. Select Mozc and enable it.
  4. Type "tesuto"

Expected behavior

  • At the step 4, Mozc's suggestion window is placed just below the composing text.

Actual behavior

  • At the step 4, Mozc's suggestion window is placed of the place from the composing text.

Screenshots

per-monitor-dpi

Version or commit-id

af20906

Environment

  • OS: OS: Windows 11 22H2
  • Related Applications: Any
hiroyuki-komatsu added a commit that referenced this issue Oct 26, 2023
@hiroyuki-komatsu
Update BUILD_OSS to 5268
242f240 
Typing quality
* Added  鵼(ぬえ) and 喃(のう) to the word dictionary.

Linux
* Fixed the crash issue of the candidate window UI (#820)

Windows
* Enabled the candidate window to respect the vertical writing mode (#362)
* Updated InputScope mapping to be compatible with MS-IME as of Windows 11 22H2 (#818, #826)
* Addressed the issue of no response on MS-Word (#819)
* Enabled the candidate window to consider per-monitor DPI settings (#832)

Build
* Enabled C++20 (#783)
* Switched to Qt 6.6.0 for Windows and macOS (#833)
* Reduced Qt6 binary size (#822)
* macOS: Fixed the non executable error of GUI tools with GYP
* Windows: Stopped specifying /BASE option (#834)
* Windows: Enabled Hardware Enforced Stack Protection (#835)
* Windows: Set default dependent load flags to Mozc executables for Windows (#836)
* Windows: Removed the dependency on CoCreateInpustance from mozc_tip dlls (#837)

PiperOrigin-RevId: 576830216
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
@yukawa @coooooooozy
Fix window locations under Per-Monitor DPI in Windows
4af9688 
This is a minimum change to place candidate windows around the cursor
location even under Per-Monitor DPI mode in Windows.

Note that there are still known issues that 'mozc_render' continues
using the initial DPI.  Watch google#831 for such remaining issues.

Closes google#832.

PiperOrigin-RevId: 575633393
coooooooozy pushed a commit to coooooooozy/mozc that referenced this issue Nov 26, 2023
@hiroyuki-komatsu @coooooooozy
Update BUILD_OSS to 5268
1e332e0 
Typing quality
* Added  鵼(ぬえ) and 喃(のう) to the word dictionary.

Linux
* Fixed the crash issue of the candidate window UI (google#820)

Windows
* Enabled the candidate window to respect the vertical writing mode (google#362)
* Updated InputScope mapping to be compatible with MS-IME as of Windows 11 22H2 (google#818, google#826)
* Addressed the issue of no response on MS-Word (google#819)
* Enabled the candidate window to consider per-monitor DPI settings (google#832)

Build
* Enabled C++20 (google#783)
* Switched to Qt 6.6.0 for Windows and macOS (google#833)
* Reduced Qt6 binary size (google#822)
* macOS: Fixed the non executable error of GUI tools with GYP
* Windows: Stopped specifying /BASE option (google#834)
* Windows: Enabled Hardware Enforced Stack Protection (google#835)
* Windows: Set default dependent load flags to Mozc executables for Windows (google#836)
* Windows: Removed the dependency on CoCreateInpustance from mozc_tip dlls (google#837)

PiperOrigin-RevId: 576830216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yukawa