Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GLPK library naming on windows #4447

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Handle GLPK library naming on windows #4447

merged 1 commit into from
Nov 26, 2024

Conversation

jamiecook
Copy link

libglpk.a on linux, GLPK.lib on windows.

libglpk.a on linux, GLPK.lib on windows.
@Mizux Mizux self-assigned this Nov 21, 2024
@Mizux Mizux added Bug OS: Windows Windows OS labels Nov 21, 2024
@Mizux
Copy link
Collaborator

Mizux commented Nov 22, 2024

AFAIK this file is for windows only but:

  1. I didn't bump it since we use dynamic library (protobuf abseil-cpp) -> May need some extra changes
  2. Why talking about Linux naming ?, this file is only a post process for windows, or is it for reference ?
  3. Since it is windows only, why using *glpk.lib instead of just glpk.lib i.e. do you have some use case where the "*" is necessary/mandatory ?

BTW thx for this PR we definitively need to take a look at this file before next release

@Mizux Mizux added this to the v9.12 milestone Nov 22, 2024
@Mizux Mizux added the Build: CMake CMake based build issue label Nov 22, 2024
@jamiecook
Copy link
Author

jamiecook commented Nov 23, 2024 via email

@Mizux Mizux merged commit 49aa19d into google:main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Build: CMake CMake based build issue OS: Windows Windows OS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants