Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader stage does matter for preprocessing #1366

Open
benjamin-otte opened this issue Aug 19, 2023 · 0 comments
Open

Shader stage does matter for preprocessing #1366

benjamin-otte opened this issue Aug 19, 2023 · 0 comments

Comments

@benjamin-otte
Copy link

https://github.com/google/shaderc/blob/main/libshaderc_util/src/compiler.cc#L468C10-L468C11 claims:

  // The stage does not matter for preprocessing.
  glslang::TShader shader(EShLangVertex);

However, glslang does use the language for setting defines in https://github.com/KhronosGroup/glslang/blob/main/glslang/MachineIndependent/Versions.cpp#L642

The result of this mismatch is that GL_VERTEX_SHADER is defined for every shader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant