Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSLX array concat is not documented well #1730

Open
mikex-oss opened this issue Nov 19, 2024 · 0 comments
Open

DSLX array concat is not documented well #1730

mikex-oss opened this issue Nov 19, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation dslx DSLX (domain specific language) implementation / front-end

Comments

@mikex-oss
Copy link
Collaborator

++ working on concat is buried in an example under the "array conversion" subsection talking about converting to bits. https://google.github.io/xls/dslx_reference/#:~:text=fn%20concat_arrays(a%3A%20u2%5B3%5D%2C%20b%3A%20u2%5B3%5D)%20%2D%3E%20u2%5B6%5D%20%7B%0A%20%20a%20%2B%2B%20b%0A%7D

It would be good to document it explicitly in https://google.github.io/xls/dslx_reference/#concat-expression, which currently can be misinterpreted to only apply to bits (many things that work on bits do not work on arrays).

Related: #1619

@mikex-oss mikex-oss added documentation Improvements or additions to documentation dslx DSLX (domain specific language) implementation / front-end labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation dslx DSLX (domain specific language) implementation / front-end
Projects
Status: No status
Development

No branches or pull requests

1 participant