Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement][DSLX:LSP] Language server could save all "crashes" #1934

Open
cdleary opened this issue Feb 15, 2025 · 0 comments
Open

[enhancement][DSLX:LSP] Language server could save all "crashes" #1934

cdleary opened this issue Feb 15, 2025 · 0 comments
Labels
dslx:lsp DSLX language server/protocol implementation enhancement New feature or request

Comments

@cdleary
Copy link
Collaborator

cdleary commented Feb 15, 2025

What's hard to do? (limit 100 words)

If there's a XLS_RET_CHECK that happens for some intermediate buffer state it'd be great to have a dump of the language server that caused the internal error to occur.

Because we don't have this, we can encounter transient issues that are hard to recover the input stimulus for.

Current best alternative workaround (limit 100 words)

Be very careful when making edits or very cognizant of when an internal error happens in the language server.

Your view of the "best case XLS enhancement" (limit 100 words)

We get something like a flag --dump_internal_errors_to=/tmp/dir/ where it can dump language server state that exhibits the error and maybe a tool that helps us replay those for reproduction.

@cdleary cdleary added dslx:lsp DSLX language server/protocol implementation enhancement New feature or request labels Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dslx:lsp DSLX language server/protocol implementation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant