Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve reserved keyword conflict with variable names in path patterns #1090

Open
aandreassa opened this issue Jul 9, 2024 · 2 comments
Open
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@aandreassa
Copy link
Contributor

aandreassa commented Jul 9, 2024

googleapis/google-cloud-ruby#26358 introduced a path variable module, which conflicts with reserved keywords, failing generation.

Current plan is:

  1. Introduce an owlbot rule to affected library and unblock generation (adding sufix _param).
  2. Add a fix to the generator itself, where keyword names will be properly escaped.

Note: google-cloud-support-v2/.owlbot.rb already contains a similar patch and should be tested on upcoming change. In that example, the word case gets converted to ccase.

For reference, PiperOrigin-RevId: 650374217

Pointers: #1086

@aandreassa aandreassa added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 9, 2024
@aandreassa aandreassa assigned aandreassa and unassigned dazuma Jul 17, 2024
@dazuma
Copy link
Member

dazuma commented Aug 2, 2024

It looks like google-cloud-support-v2 is a different issue. It's not a path parameter, but a local variable in a test case. We probably need to fix that case in the generator as well.

@aandreassa
Copy link
Contributor Author

#1101 should address the last issue we had on naming the local variables. Once the pending PR's are in, I can get started on the generator release to close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants