Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FieldPresenter test #65

Closed
blowmage opened this issue Mar 20, 2019 · 4 comments
Closed

Add FieldPresenter test #65

blowmage opened this issue Mar 20, 2019 · 4 comments
Assignees
@blowmage
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@blowmage
Copy link
Contributor

No description provided.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Aug 1, 2019
@dazuma dazuma added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Aug 7, 2019
@jbolinger jbolinger mentioned this issue Aug 21, 2019
Merged
@jbolinger
Copy link
Contributor

@blowmage feel free to add what's still missing after #217 and I can probably pick this one up and close it out if you'd like.

@dazuma
Copy link
Member

dazuma commented Dec 13, 2019

We still may need to flesh out more test cases from the garbage protos.

@dazuma
Copy link
Member

dazuma commented Dec 13, 2019

verify that this is fully complete

@blowmage
Copy link
Contributor Author

We have tests https://github.com/googleapis/gapic-generator-ruby/blob/master/gapic-generator/test/gapic/presenters/field_presenter_test.rb and https://github.com/googleapis/gapic-generator-ruby/blob/master/gapic-generator/test/gapic/presenters/field_presenter_showcase_test.rb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blowmage blowmage

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@blowmage @dazuma @jbolinger @yoshi-automation