address comments; get quickstart builds working

googleapis · Dec 10, 2024 · 13059dd · 13059dd
1 parent 62b91b5
commit 13059dd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/ci/cloudbuild/builds/quickstart-cmake.sh b/ci/cloudbuild/builds/quickstart-cmake.sh
@@ -47,6 +47,8 @@ readonly SED_ARGS=(
   # The vcpkg maintainers introduced an `rpc` feature to just compile
   # `grpc-common`.
   -e '/^rpc$/d'
+  # TODO(#14891) - skip until next release
+  -e '/^bigquerycontrol/d'
 )
 mapfile -t features < <(
   env -C "${vcpkg_dir}" ./vcpkg search google-cloud-cpp |

diff --git a/google/cloud/bigquerycontrol/README.md b/google/cloud/bigquerycontrol/README.md
@@ -1,14 +1,12 @@
 # BigQuery API C++ Client Library
 
-:construction:
-
 This directory contains an idiomatic C++ client library for the
 [BigQuery API][cloud-service-docs].
 
 A data platform for customers to create, manage, share and query data.
 
 While this library is **GA**, please note Google Cloud C++ client libraries do
- **not** follow [Semantic Versioning](https://semver.org/).
+**not** follow [Semantic Versioning](https://semver.org/).
 
 ## Quickstart
 

diff --git a/google/cloud/bigquerycontrol/config.cmake.in b/google/cloud/bigquerycontrol/config.cmake.in
@@ -22,3 +22,8 @@ find_dependency(google_cloud_cpp_rest_protobuf_internal)
 find_dependency(absl)
 
 include("${CMAKE_CURRENT_LIST_DIR}/google_cloud_cpp_bigquerycontrol-targets.cmake")
+
+# Remove this after bigquerycontrol is promoted from transitional to GA.
+if (NOT TARGET google-cloud-cpp::experimental-bigquerycontrol)
+    add_library(google-cloud-cpp::experimental-bigquerycontrol ALIAS google-cloud-cpp::bigquerycontrol)
+endif ()