From 66a0da690b8c60ba5cb109c05b73aefb13e4ca95 Mon Sep 17 00:00:00 2001 From: dbolduc Date: Fri, 12 Jul 2024 10:32:10 -0400 Subject: [PATCH] ci: reduce spanner CreateInstance rpcs in daily build --- .../integration_tests/instance_admin_integration_test.cc | 7 +++---- .../instance_admin_rest_integration_test.cc | 7 +++---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/google/cloud/spanner/admin/integration_tests/instance_admin_integration_test.cc b/google/cloud/spanner/admin/integration_tests/instance_admin_integration_test.cc index 4bff744900a0f..c45f27c997a9a 100644 --- a/google/cloud/spanner/admin/integration_tests/instance_admin_integration_test.cc +++ b/google/cloud/spanner/admin/integration_tests/instance_admin_integration_test.cc @@ -215,10 +215,9 @@ TEST_F(InstanceAdminClientTest, InstanceCRUDOperations) { } TEST_F(InstanceAdminClientTest, CreateInstanceStartAwait) { - if (!Emulator() && !RunSlowInstanceTests()) { - GTEST_SKIP() << "skipping slow instance tests; set " - << "GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS=instance" - << " to override"; + if (!Emulator()) { + GTEST_SKIP() << "skipping, as there is a quota on CreateInstance requests " + "against production."; } Instance in(ProjectId(), spanner_testing::RandomInstanceName(generator_)); diff --git a/google/cloud/spanner/admin/integration_tests/instance_admin_rest_integration_test.cc b/google/cloud/spanner/admin/integration_tests/instance_admin_rest_integration_test.cc index 9ebb841232f67..9bdbf134e80bd 100644 --- a/google/cloud/spanner/admin/integration_tests/instance_admin_rest_integration_test.cc +++ b/google/cloud/spanner/admin/integration_tests/instance_admin_rest_integration_test.cc @@ -259,10 +259,9 @@ TEST_F(InstanceAdminClientRestTest, InstanceCRUDOperations) { } TEST_F(InstanceAdminClientRestTest, CreateInstanceStartAwait) { - if (!Emulator() && !RunSlowInstanceTests()) { - GTEST_SKIP() << "skipping slow instance tests; set " - << "GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS=instance" - << " to override"; + if (!Emulator()) { + GTEST_SKIP() << "skipping, as there is a quota on CreateInstance requests " + "against production."; } Instance in(ProjectId(), spanner_testing::RandomInstanceName(generator_));