From d06ba828ffd299032aa727076236fd923394fbff Mon Sep 17 00:00:00 2001 From: Carlos O'Ryan Date: Fri, 28 Jun 2024 00:24:36 +0000 Subject: [PATCH] test(GCS+gRPC): skip another integration test This one does not work against production, and it may never work against production. Disable it until I can get an authoritative answer. --- .../storage/tests/grpc_notification_integration_test.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/google/cloud/storage/tests/grpc_notification_integration_test.cc b/google/cloud/storage/tests/grpc_notification_integration_test.cc index f9fdc4fadf985..69546adad8d9d 100644 --- a/google/cloud/storage/tests/grpc_notification_integration_test.cc +++ b/google/cloud/storage/tests/grpc_notification_integration_test.cc @@ -39,6 +39,12 @@ class GrpcNotificationIntegrationTest : public google::cloud::storage::testing::StorageIntegrationTest {}; TEST_F(GrpcNotificationIntegrationTest, NotificationCRUD) { + // TODO(#14396) - figure out what to do with the Notifications and gRPC + if (UsingGrpc()) GTEST_SKIP(); + + ScopedEnvironment grpc_config("GOOGLE_CLOUD_CPP_STORAGE_GRPC_CONFIG", + "metadata"); + auto const project_id = GetEnv("GOOGLE_CLOUD_PROJECT").value_or(""); ASSERT_THAT(project_id, Not(IsEmpty())) << "GOOGLE_CLOUD_PROJECT is not set"; auto const topic_name = google::cloud::internal::GetEnv( @@ -55,9 +61,6 @@ TEST_F(GrpcNotificationIntegrationTest, NotificationCRUD) { ASSERT_STATUS_OK(metadata); ScheduleForDelete(*metadata); - ScopedEnvironment grpc_config("GOOGLE_CLOUD_CPP_STORAGE_GRPC_CONFIG", - "metadata"); - auto marker = google::cloud::internal::Sample( generator_, 16, "abcdefghijklmnopqrstuvwxyz0123456789"); auto create = client->CreateNotification(