Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add new build universe-domain #14866

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented Dec 2, 2024

I am renaming the build universe-domain-demo to universe-domain.

This is the first step - create a new build named universe-domain.


This change is Reviewable

@cuiy0006 cuiy0006 marked this pull request as ready for review December 2, 2024 21:50
@cuiy0006 cuiy0006 requested a review from a team as a code owner December 2, 2024 21:50
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I see that this PR is copying existing code. I left questions to think about, but feel free to merge this PR as it is now.

ci/cloudbuild/builds/universe-domain.sh Show resolved Hide resolved
ci/cloudbuild/builds/universe-domain.sh Show resolved Hide resolved
@dbolduc
Copy link
Member

dbolduc commented Dec 3, 2024

/gcbrun

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (80060d5) to head (97ca577).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14866      +/-   ##
==========================================
- Coverage   93.00%   93.00%   -0.01%     
==========================================
  Files        2351     2351              
  Lines      209479   209479              
==========================================
- Hits       194834   194831       -3     
- Misses      14645    14648       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuiy0006 cuiy0006 merged commit 6026c70 into googleapis:main Dec 3, 2024
74 checks passed
@cuiy0006 cuiy0006 deleted the add-trigger-universe-domain branch December 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants