Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support distributed tracing across Pub/Sub #9157

Closed
EricStG opened this issue Sep 26, 2022 · 2 comments
Closed

Support distributed tracing across Pub/Sub #9157

EricStG opened this issue Sep 26, 2022 · 2 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@EricStG
Copy link

EricStG commented Sep 26, 2022

Is your feature request related to a problem? Please describe.
I want to be able to correlate distributed traces for requests sent over pub/sub

Describe the solution you'd like
Ideally, support for OpenTelemetry that will:

  • Create a new activity when sending/receiving messages
  • Enrich pub/sub messages with the attributes for correlation / baggage propagation

Describe alternatives you've considered
We're doing it manually for now with the OpenTelemetry propagators.

Additional context
Similar to #8366, but we haven't had issues with automated instrumentation over HTTP, but pub/sub is a big blindspot for us.
Sounds like there are internal discussions around supporting this over different languages like golang and nodejs, but can't tell how far those discussions have gone

@jskeet jskeet added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: pubsub Issues related to the Pub/Sub API. labels Sep 27, 2022
@jskeet
Copy link
Collaborator

jskeet commented Sep 27, 2022

Assigning to Amanda for comment as she knows more about OpenTelemetry than I do. (But fundamentally I wouldn't expect to see anything here soon.)

@amanda-tarafa
Copy link
Contributor

@EricStG Yes, there are ongoing discussion to support OpenTelemetry for all libraries, inlcuding Pub/Sub, across all languages, including .NET, but those are on very early stages. As @jskeet said, don't expect anything soon.

It seems you already have implemented tracing manually, so this might no be useful for you, but you can use Google.Cloud.Diagnostics.Common to add tracing to non-HTTP contexts. Apart from the linked docs, see #5897 and #6367 for more context. And of course, create specific issues if you have questions or run into problems.

If it's OK I'd prefer to close this issue as a duplicate of #8366 as we are including Pub/Sub in all our explorations.

@EricStG EricStG closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants