-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding a simple trace correlation mechanism to Google.Cloud.Logging.Console. #9948
Comments
any progress on this ? I make no progress on #9868 (still missing traces with SizedBuffer and even with NoBuffer) so maybe this soluiton could get me out of troubles (i.e avoid grpc calls for logs/traces that are slowing done http requests) |
I'm out sick, but I'll try and see what I can do as soon after I'm back. Mid to late week most likely. Sorry for the wait, we'll get there. |
Just a note: we are considering the options here, I'll update when I know more. |
Quick update, we are working on this. We have a tentive proposal that if approved, we should start implementing in the next few days. |
We can close this once the documentation is updated with the desired level of information. |
Closing - the code has been released, and the docs will be published at https://cloud.google.com/dotnet/docs/reference/Google.Cloud.Logging.Console/latest in due course. (It takes a while for them to be processed.) |
Hi @jskeet and @amanda-tarafa Sorry for the delay, we had another project in front of this one... I've followed the documentation, it is working : I can see logs in Logs explorer and I can click on the left arrow to see all logs of the same trace However, the view trace details is not working Here is an example project (be aware to replace values in cloudbuild.yaml / cloudrun.yaml) Given the doc https://cloud.google.com/dotnet/docs/reference/Google.Cloud.Logging.Console/latest#log-trace-correlation, I'd expect traces to work
IMHO, the point 2 is the issue : the doc says "by default Cloud run exports traces" but this is not the case I think => how can we diagnose this point ? should i open a new issue ? |
Yes please, can you create a new issue with the repro? I'll take a look as soon as I'm able. |
This would allow applications already in posession of a collected trace context to specify it on log entries so they are correlated.
Out of scope: any mechanism to create, augment, or collect trace contexts.
To provide an alternative for #9868 use case.
The text was updated successfully, but these errors were encountered: