Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: spansql.ParseDDL support for ARRAY<FLOAT32> #11106

Open
ajroetker opened this issue Nov 8, 2024 · 0 comments
Open

spanner: spansql.ParseDDL support for ARRAY<FLOAT32> #11106

ajroetker opened this issue Nov 8, 2024 · 0 comments
Assignees
Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.

Comments

@ajroetker
Copy link

Client

Spanner

Expected vs actual behavior

We use the GoLang Spanner client to manage migrations of our Spanner DDL.
Spanner supports ARRAY for Vector Search which is half the byte cost of ARRAY.
We'd like to use a FLOAT32 but https://github.com/googleapis/google-cloud-go/blob/main/spanner/spansql/parser.go#L3202 does not support parsing ARRAY as valid DDL.

Additional context

Easy test, this works on spanner but not with spansql.ParseDDL

CREATE TABLE vectorTest (
  id STRING(MAX),
  vector ARRAY<FLOAT32>,
)
PRIMARY KEY (id);
@ajroetker ajroetker added the triage me I really want to be triaged. label Nov 8, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants