Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: Suppress client is closing errors when using emulator/fake #2950

Closed
hongalex opened this issue Oct 1, 2020 · 0 comments · Fixed by #2951
Closed

pubsub: Suppress client is closing errors when using emulator/fake #2950

hongalex opened this issue Oct 1, 2020 · 0 comments · Fixed by #2951
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@hongalex
Copy link
Member

hongalex commented Oct 1, 2020

We should suppress the "client conn is closing" errors in general since it will only happen in environments that are not hitting the live pub/sub service.

In addition, should fix the typos in the error messages.

Originally posted by @xmlking in #2867 (comment)
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 1, 2020
@hongalex hongalex self-assigned this Oct 1, 2020
@hongalex hongalex mentioned this issue Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pubsub): suppress connection is closing error googleapis/google-cloud-go
1 participant
@hongalex