Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant explicit links #1285

Open
coryan opened this issue Feb 14, 2025 · 0 comments
Open

Remove redundant explicit links #1285

coryan opened this issue Feb 14, 2025 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. sidekick Issues related to the code generator type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented Feb 14, 2025

Sometimes the comments have links that point to the same thing, as in:

// Say something deep about [Foo][google.cloud.foo.v1.Foo]
message Foo 

That ends up emitting code that references the same thing:

/// Say something deep about [Foo][google.cloud.foo.v1.Foo]
///
/// [google.cloud.foo.v1.Foo]: crate::model::Foo
struct Foo ... 

The generated code could be simpler, just:

/// Say something deep about [Foo]
struct Foo ... 
@coryan coryan added priority: p3 Desirable enhancement or fix. May not be included in next release. sidekick Issues related to the code generator type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. sidekick Issues related to the code generator type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant