Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map messages should not be child messages #1381

Open
coryan opened this issue Feb 26, 2025 · 0 comments
Open

Map messages should not be child messages #1381

coryan opened this issue Feb 26, 2025 · 0 comments
Labels
sidekick Issues related to the code generator type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented Feb 26, 2025

Map fields are represented as (synthetic) child messages of the message that contains the field. Then in the Mustache templates we need to ignore them:

We should consider adding these messages to the MessageById table, but not to the child messages. We can simplify the mustache templates, and avoid thinking about these so much.

@coryan coryan added type: cleanup An internal cleanup or hygiene concern. sidekick Issues related to the code generator labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sidekick Issues related to the code generator type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant