Skip to content

Commit

Permalink
chore: Address comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
blakeli0 committed Oct 30, 2024
1 parent a7f5101 commit df57b82
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion libraries-bom-protobuf3/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom-protobuf3</artifactId>
<version>26.50.0-SNAPSHOT</version><!-- {x-version-update:libraries-bom-protobuf3:current} -->
<version>26.50.0-SNAPSHOT</version><!-- {x-version-update:libraries-bom:current} -->
<packaging>pom</packaging>

<parent>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ private void printKeyCoreLibraryDependencies(Bom bom) {
.append(versionlessCoordinatesToVersion.get("com.google.cloud:google-cloud-core"))
.append("\n");
report
.append("If you encounter compatibility issues with protobuf-java 4.x, please update your codebase and dependencies to ensure compatibility. If this is not feasible, you may use libraries-bom-protobuf3 as a workaround. This option utilizes protobuf-java 3.x and provides the same client libraries as libraries-bom.")
.append("If you encounter compatibility issues with protobuf-java 4.x, please update your codebase and dependencies to ensure compatibility. If this is not feasible, as a workaround, use libraries-bom-protobuf3 which is compatible with protobuf-java 3.x. libraries-bom-protobuf3 includes the same client libraries and library versions as libraries-bom.")
.append("\n");
}

Expand Down
1 change: 0 additions & 1 deletion versions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@

google-cloud-bom:0.230.0:0.231.0-SNAPSHOT
libraries-bom:26.49.0:26.50.0-SNAPSHOT
libraries-bom-protobuf3:26.49.0:26.50.0-SNAPSHOT
java-cloud-bom-tests:0.45.0:0.46.0-SNAPSHOT
full-convergence-check:0.48.0:0.49.0-SNAPSHOT

0 comments on commit df57b82

Please sign in to comment.