Skip to content

Commit

Permalink
fix: Swap writer and reader schema to correct places in sample (#1849)
Browse files Browse the repository at this point in the history
* samples: schema evolution

* samples: schema evolution

* Format fixes

* Fix documentation for field.

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add back in working asserts

* Formatting fixes

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Version/delete fixes

* samples: schema evolution

* samples: schema evolution

* Format fixes

* Fix documentation for field.

* Add back in working asserts

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Formatting fixes

* Version/delete fixes

* samples: Schema evolution (#1499)

* samples: schema evolution

* samples: schema evolution

* Format fixes

* Fix documentation for field.

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add back in working asserts

* Formatting fixes

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Version/delete fixes

* samples: schema evolution

* samples: schema evolution

* Format fixes

* Fix documentation for field.

* Add back in working asserts

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Formatting fixes

* Version/delete fixes

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* Minor fixes for comments

* samples: Schema evolution (#1499)

* samples: schema evolution

* samples: schema evolution

* Format fixes

* Fix documentation for field.

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add back in working asserts

* Formatting fixes

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Version/delete fixes

* samples: schema evolution

* samples: schema evolution

* Format fixes

* Fix documentation for field.

* Add back in working asserts

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Formatting fixes

* Version/delete fixes

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* Fix rollback example

* Formatting

* Formatting and wording fixes

* Add new schemas to test directory

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Samples: Fix exception handling

* fix: Set x-goog-request-params for streaming pull request

* Revert "fix: Set x-goog-request-params for streaming pull request"

This reverts commit 3185a3e.

* Revert "Revert "fix: Set x-goog-request-params for streaming pull request""

This reverts commit 3b1f4d9.

* Thread example

* Add examples for limited and unlimited exeuctors

* Add back missing semicolon

* Revert changes to original async example

* Revert changes to original async example

* Add examples of different threading models

* Make variables final to conform to style.

* Fix catches

* Fix ids

* Fix naming

* Revert "Merge pull request #2 from kamalaboulhosn/ML_experiments"

This reverts commit 5a435fa, reversing
changes made to c3a5725.

* Set blunderbuss config to auto-assign issues and PRs

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: Swap writer and reader schema to correct places in sample

* πŸ¦‰ Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
kamalaboulhosn and gcf-owl-bot[bot] authored Dec 19, 2023
1 parent a5b4d5e commit 1c79ad7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public static void subscribeWithAvroSchemaRevisionsExample(
Schema schema = schemaServiceClient.getSchema(name + "@" + revision);
org.apache.avro.Schema avroSchema =
new org.apache.avro.Schema.Parser().parse(schema.getDefinition());
reader = new SpecificDatumReader<State>(State.getClassSchema(), avroSchema);
reader = new SpecificDatumReader<State>(avroSchema, State.getClassSchema());
synchronized (revisionReaders) {
revisionReaders.put(revision, reader);
}
Expand Down

0 comments on commit 1c79ad7

Please sign in to comment.