fix: Fix build errors in Publisher

googleapis · Jul 2, 2024 · e21a9f0 · e21a9f0
1 parent b0e0424
commit e21a9f0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
@@ -275,9 +275,7 @@ public ApiFuture<String> publish(PubsubMessage message) {
 
     PubsubMessageWrapper messageWrapper =
         PubsubMessageWrapper.newBuilder(
-                messageTransform.apply(message),
-                TopicName.parse(topicName),
-                enableOpenTelemetryTracing)
+                messageTransform.apply(message), topicName, enableOpenTelemetryTracing)
             .build();
     messageWrapper.startPublisherSpan(tracer);
 

diff --git a/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenTelemetryTest.java b/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenTelemetryTest.java
@@ -67,7 +67,8 @@ public void testPublishSpansSuccess() {
     openTelemetryTesting.clearSpans();
 
     PubsubMessageWrapper messageWrapper =
-        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME, true).build();
+        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME.toString(), true)
+            .build();
     List<PubsubMessageWrapper> messageWrappers = Arrays.asList(messageWrapper);
 
     long messageSize = messageWrapper.getPubsubMessage().getData().size();
@@ -182,7 +183,8 @@ public void testPublishFlowControlSpanFailure() {
     openTelemetryTesting.clearSpans();
 
     PubsubMessageWrapper messageWrapper =
-        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME, true).build();
+        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME.toString(), true)
+            .build();
 
     Tracer tracer = openTelemetryTesting.getOpenTelemetry().getTracer("test");
 
@@ -221,7 +223,8 @@ public void testPublishBatchingSpanFailure() {
     openTelemetryTesting.clearSpans();
 
     PubsubMessageWrapper messageWrapper =
-        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME, true).build();
+        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME.toString(), true)
+            .build();
 
     Tracer tracer = openTelemetryTesting.getOpenTelemetry().getTracer("test");
 
@@ -259,7 +262,8 @@ public void testPublishRpcSpanFailure() {
     openTelemetryTesting.clearSpans();
 
     PubsubMessageWrapper messageWrapper =
-        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME, true).build();
+        PubsubMessageWrapper.newBuilder(getPubsubMessage(), FULL_TOPIC_NAME.toString(), true)
+            .build();
 
     List<PubsubMessageWrapper> messageWrappers = Arrays.asList(messageWrapper);
     Tracer tracer = openTelemetryTesting.getOpenTelemetry().getTracer("test");