fix: propagate set options to LeaseManager (from #1880) (#1954)

Bringing this over from https://togithub.com/googleapis/nodejs-pubsub/pull/1880 (dermasmid@) so I can work CI on it. Fixes https://togithub.com/googleapis/nodejs-pubsub/issues/1879
googleapis · Aug 26, 2024 · cdb0916 · cdb0916
1 parent f082869
commit cdb0916
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/subscriber.ts b/src/subscriber.ts
@@ -993,11 +993,16 @@ export class Subscriber extends EventEmitter {
 
       const {maxStreams = defaultOptions.subscription.maxStreams} =
         options.streamingOptions;
+
       options.streamingOptions.maxStreams = Math.min(
         maxStreams,
         this.maxMessages
       );
     }
+
+    if (this._inventory) {
+      this._inventory.setOptions(this._options.flowControl!);
+    }
   }
 
   /**

diff --git a/test/subscriber.ts b/test/subscriber.ts
@@ -95,6 +95,8 @@ class FakeLeaseManager extends EventEmitter {
   }
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   add(message: s.Message): void {}
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  setOptions(options: FlowControlOptions): void {}
   clear(): s.Message[] {
     return [];
   }
@@ -115,6 +117,8 @@ class FakeQueue {
   async add(message: s.Message, deadline?: number): Promise<s.AckResponse> {
     return s.AckResponses.Success;
   }
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  setOptions(options: BatchOptions) {}
   async flush(): Promise<void> {}
   async onFlush(): Promise<void> {}
   async onDrain(): Promise<void> {}