-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do I get on the latest version of @grpc/grpc-js? #789
Comments
@bcoe so there are no code changes? I merely bring in the latest changes? |
@npomfret correct, we are in the process of updating everything explicitly across all our libraries, so it would be good to check after the update, with |
@bcoe Given the issues with |
@Legogris if you are running into the memory leak described in 1085, I recommend potentially running the C++ grpc version for the time being: https://github.com/googleapis/nodejs-pubsub#running-grpc-c-bindings Once tested, we will work with the gRPC team to get a patch for the memory leak described in grpc/grpc-node#1085 out ASAP. |
@bcoe The weird thing is our issues are manifesting primarily as a memory leak (although too many sockets/connection could definitely be part of the story). Basically we are running a system that is doing a lout of outbound HTTP requests and posting parsed results through PubSub, and the recent versions result in a lot of timeouts for those outbound requests (not the ones to PubSub). I did try running the C++ Reverting to the following versions is the least problematic so far, and I have no satisfactory explanation to why. Memory and CPU usage does not explain this for when we're using
Perhaps part of the issue originates from changes in Will be keen to give the next version a spin. Thank you for the diligence and following up. |
@Legogris it might be worth bringing the conversation over to #788, because this conversation is related specifically to memory issues. I'm sharing your updates with internal folks, and we're in the process of discussing what might be causing these memory issues. If possible could you share some sample code demonstrating how you initialize your client? |
I'm going to go ahead and close this since we haven't needed to manually bump anyone to newer grpc-js lately, but please feel free to comment and/or re-open if needed. |
Over the past few weeks there were a few bad releases of
@grpc/grpc-js
that went out the door, and effect the behavior of@google-cloud/pubsub
, and other libraries that rely ongrpc
.There is now a version of
@grpc/grpc-js
available,0.6.9
, which has addressed a variety of stability issues.Getting on the new version
@google-cloud/pubsub
(@google-cloud/logging
, etc), deletepackage-lock.json
.node_modules/
folder, so that you will receive a fresh install.npm install
.npm ls
👈 look at this tree, it should indicate that you are on up-to-date versions of@grpc/grpc-js
, if not let us know and we can help.What if I don't want to remove my
package-lock.json
?As an alternative, you may also be able to run
npm update @grpc/grpc-js
, afterwards runnpm ls
, and confirm that all copies have been updated appropriately.see #770
@npomfret, let me know if you bump into any issues with this upgrade process, and I can help debug here.
The text was updated successfully, but these errors were encountered: