Sample tests are flaky

[JustinBeckwith]

Looking at #882, there's no reason the sample tests should be failing there.

Results are here:
https://source.cloud.google.com/results/invocations/c478b728-cd2b-4a0f-a3a5-545b2b668db1/targets/cloud-devrel%2Fclient-libraries%2Fnodejs%2Fpresubmit%2Fgoogleapis%2Fnodejs-pubsub%2Fnode10%2Fsamples-test/log

[feywind]

To be fair, this deadline exceeded thing is something we've been hearing about outside of sample tests, so this might just be the sample tests working as intended.

[JustinBeckwith]

nods I hear ya. May not be anything we're doing wrong in the code, but we can't be flakin. I'm fine with tactical retries if that's what we need here.

[feywind]

Oh I agree, I just think it's potentially nice that the tests are catching problems rather than just being flaky :)

[feywind]

I think this may also go on the flake list (though not strictly about samples, I'm okay with this issue being a bit expansive). https://github.com/googleapis/nodejs-pubsub/pull/880/checks?check_run_id=439299785

[feywind]

Combining this in here to look at, at the same time. #900

[JustinBeckwith]

Oops - apologies, forgot I had opened this one!

[feywind]

Hah, no worries. :) It technically is a separate issue to look into, though I think fixing one will probably fix the other.

[feywind]

https://github.com/googleapis/nodejs-pubsub/pull/880/checks?check_run_id=485759235

[feywind]

https://source.cloud.google.com/results/invocations/0b75c074-4b85-4193-bbc0-3a6f10dc8af9/targets/cloud-devrel%2Fclient-libraries%2Fnodejs%2Fpresubmit%2Fgoogleapis%2Fnodejs-pubsub%2Fnode10%2Fsamples-test/log

(part of #916)

[feywind]

There haven't been any sample test flakes for a while, and we have buildcop coming online for finding them individually, anyway. I'm going to go ahead and close this.