String array untyped

.gitignore

@@ -13,3 +13,4 @@ system-test/*key.json
 package-lock.json
 __pycache__
 .idea
+.vscode

src/codec.ts

@@ -589,6 +589,7 @@ interface FieldType extends Type {
  * @private
  *
  * @param {*} value - The value.
+ * @param {boolean} isArrayValue - If the value is for an array type.
  * @returns {object}
  *
  * @example
@@ -597,7 +598,7 @@ interface FieldType extends Type {
  * // {type: 'float64'}
  * ```
  */
-function getType(value: Value): Type {
+function getType(value: Value, isArrayValue = false): Type {
   const isSpecialNumber =
     is.infinite(value) || (is.number(value) && isNaN(value));
 
@@ -629,6 +630,10 @@ function getType(value: Value): Type {
     return {type: 'bool'};
   }
 
+  if (is.string(value) && isArrayValue) {
+    return {type: 'string'};
+  }
+
   if (Buffer.isBuffer(value)) {
     return {type: 'bytes'};
   }
@@ -663,7 +668,7 @@ function getType(value: Value): Type {
 
     return {
       type: 'array',
-      child: getType(child),
+      child: getType(child, true),
     };
   }
 

src/index.ts

@@ -46,7 +46,13 @@ import {
   CreateInstanceConfigCallback,
   CreateInstanceConfigResponse,
 } from './instance-config';
-import {grpc, GrpcClientOptions, CallOptions, GoogleError} from 'google-gax';
+import {
+  grpc,
+  GrpcClientOptions,
+  CallOptions,
+  GoogleError,
+  ClientOptions,
+} from 'google-gax';
 import {google, google as instanceAdmin} from '../protos/protos';
 import {
   PagedOptions,
@@ -347,6 +353,54 @@ class Spanner extends GrpcService {
     this.directedReadOptions = directedReadOptions;
   }
 
+  /**
+   * Gets the InstanceAdminClient object.
+   * The returned InstanceAdminClient object is a shared, managed instance and should not be manually closed.
+   * @returns {v1.InstanceAdminClient} The InstanceAdminClient object
+   * @example
+   *  ```
+   * const {Spanner} = require('@google-cloud/spanner');
+   * const spanner = new Spanner({
+   *    projectId: projectId,
+   *  });
+   * const instanceAdminClient = spanner.getInstanceAdminClient();
+   * ```
+   */
+  getInstanceAdminClient(): v1.InstanceAdminClient {
+    const clientName = 'InstanceAdminClient';
+    if (!this.clients_.has(clientName)) {
+      this.clients_.set(
+        clientName,
+        new v1[clientName](this.options as ClientOptions)
+      );
+    }
+    return this.clients_.get(clientName)! as v1.InstanceAdminClient;
+  }
+
+  /**
+   * Gets the DatabaseAdminClient object.
+   * The returned DatabaseAdminClient object is a managed, shared instance and should not be manually closed.
+   * @returns {v1.DatabaseAdminClient} The DatabaseAdminClient object.
+   * @example
+   * ```
+   * const {Spanner} = require('@google-cloud/spanner');
+   * const spanner = new Spanner({
+   *    projectId: projectId,
+   * });
+   * const databaseAdminClient = spanner.getDatabaseAdminClient();
+   * ```
+   */
+  getDatabaseAdminClient(): v1.DatabaseAdminClient {
+    const clientName = 'DatabaseAdminClient';
+    if (!this.clients_.has(clientName)) {
+      this.clients_.set(
+        clientName,
+        new v1[clientName](this.options as ClientOptions)
+      );
+    }
+    return this.clients_.get(clientName)! as v1.DatabaseAdminClient;
+  }
+
   /** Closes this Spanner client and cleans up all resources used by it. */
   close(): void {
     this.clients_.forEach(c => {
@@ -1741,6 +1795,8 @@ promisifyAll(Spanner, {
     'pgJsonb',
     'operation',
     'timestamp',
+    'getInstanceAdminClient',
+    'getDatabaseAdminClient',
   ],
 });
 

system-test/spanner.ts

@@ -231,6 +231,115 @@ describe('Spanner', () => {
     );
   });
 
+  describe('Autogenerated Admin Client', async () => {
+    const projectId = process.env.GCLOUD_PROJECT;
+    const instanceId = envInstanceName
+      ? envInstanceName
+      : generateName('instance');
+    const DATABASE = generateName('database');
+    const instanceAdminClient = spanner.getInstanceAdminClient();
+    const databaseAdminClient = spanner.getDatabaseAdminClient();
+
+    before(async () => {
+      assert(projectId);
+      if (generateInstanceForTest) {
+        const [operation] = await instanceAdminClient.createInstance({
+          parent: instanceAdminClient.projectPath(projectId),
+          instanceId: instanceId,
+          instance: {
+            config: instanceAdminClient.instanceConfigPath(
+              projectId,
+              'regional-us-central1'
+            ),
+            nodeCount: 1,
+            displayName: instanceId,
+            labels: {
+              cloud_spanner_samples: 'true',
+              created: Math.round(Date.now() / 1000).toString(), // current time
+            },
+          },
+        });
+        const [instance] = await operation.promise();
+        RESOURCES_TO_CLEAN.push(instance as Instance);
+      } else {
+        console.log(
+          `Not creating temp instance, using + ${instanceAdminClient.instancePath(
+            projectId,
+            envInstanceName
+          )}...`
+        );
+      }
+      const [operation] = await databaseAdminClient.createDatabase({
+        createStatement: 'CREATE DATABASE `' + DATABASE + '`',
+        extraStatements: [
+          `CREATE TABLE ${TABLE_NAME} (
+            SingerId STRING(1024) NOT NULL,
+            Name STRING(1024),
+          ) PRIMARY KEY(SingerId)`,
+        ],
+        parent: databaseAdminClient.instancePath(projectId, instanceId),
+      });
+      await operation.promise();
+    });
+
+    describe('Instances', () => {
+      it('should have created the instance', async () => {
+        assert(projectId);
+        try {
+          const [metadata] = await instanceAdminClient.getInstance({
+            name: instanceAdminClient.instancePath(projectId, instanceId),
+          });
+          assert.strictEqual(
+            metadata!.name,
+            instanceAdminClient.instancePath(projectId, instanceId)
+          );
+        } catch (err) {
+          if (!err) {
+            assert.ifError(err);
+          }
+        }
+      });
+
+      it('should list the instances', async () => {
+        assert(projectId);
+        const [instances] = await instanceAdminClient.listInstances({
+          parent: instanceAdminClient.projectPath(projectId),
+        });
+        assert(instances!.length > 0);
+      });
+    });
+
+    describe('Databases', () => {
+      async function createDatabase(database, dialect) {
+        assert(projectId);
+        const [metadata] = await databaseAdminClient.getDatabase({
+          name: databaseAdminClient.databasePath(
+            projectId,
+            instanceId,
+            database
+          ),
+        });
+        assert.strictEqual(
+          metadata!.name,
+          databaseAdminClient.databasePath(projectId, instanceId, database)
+        );
+        assert.strictEqual(metadata!.state, 'READY');
+        if (IS_EMULATOR_ENABLED) {
+          assert.strictEqual(
+            metadata!.databaseDialect,
+            'DATABASE_DIALECT_UNSPECIFIED'
+          );
+        } else {
+          assert.strictEqual(metadata!.databaseDialect, dialect);
+        }
+      }
+
+      it('GOOGLE_STANDARD_SQL should have created the database', async () => {
+        createDatabase(DATABASE, 'GOOGLE_STANDARD_SQL');
+      });
+    });
+  });
+
   describe('types', () => {
     const TABLE_NAME = 'TypeCheck';
     const googleSqlTable = DATABASE.table(TABLE_NAME);
@@ -1322,6 +1431,46 @@ describe('Spanner', () => {
         );
       });
 
+      it('GOOGLE_STANDARD_SQL should query untyped string array values', function (done) {
+        if (IS_EMULATOR_ENABLED) {
+          this.skip();
+        }
+
+        const value = ['ghi', 'jkl'];
+        const table = googleSqlTable;
+
+        const query: ExecuteSqlRequest = {
+          sql:
+            'SELECT * FROM `' +
+            table.name +
+            '` WHERE EXISTS (SELECT 1 FROM UNNEST(StringArray) AS c WHERE c IN UNNEST(@value))',
+          params: {
+            value,
+          },
+        };
+
+        insert(
+          {StringArray: value},
+          Spanner.GOOGLE_STANDARD_SQL,
+          (err, row) => {
+            assert.ifError(err);
+            assert.deepStrictEqual(row.toJSON().StringArray, ['ghi', 'jkl']);
+
+            DATABASE.run(query, (err, rows) => {
+              if (err) {
+                assert.ifError(err);
+                done();
+              }
+              assert.deepStrictEqual(rows!.shift()!.toJSON().StringArray, [
+                'ghi',
+                'jkl',
+              ]);
+              done();
+            });
+          }
+        );
+      });
+
       it('GOOGLE_STANDARD_SQL should read untyped string values', function (done) {
         if (IS_EMULATOR_ENABLED) {
           this.skip();

test/index.ts

@@ -91,6 +91,8 @@ const fakePfy = extend({}, pfy, {
       'pgJsonb',
       'operation',
       'timestamp',
+      'getInstanceAdminClient',
+      'getDatabaseAdminClient',
     ]);
   },
 });