Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: finish updating conformance test upload cases #2193

Open
tritone opened this issue May 8, 2023 · 2 comments
Open

test: finish updating conformance test upload cases #2193

tritone opened this issue May 8, 2023 · 2 comments
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@tritone
Copy link
Contributor

tritone commented May 8, 2023

In #2190 I tried to add two new upload cases including 408 errors. One of them was fine, but the case "instructions": ["return-503-after-8192K", "return-408"] failed with the following error on various upload methods:

RangeError: The offset is lower than the number of bytes written. The server has 0 bytes and while 8388608 bytes has been uploaded - thus 8388608 bytes are missing. Stopping as this could result in data loss. Initiate a new upload to continue.

This looks like a bug in resetting the offset for the upload after a failure. It may be a bug in the testbench for some particular case; however, I tested manually and verified that the testbench correctly implements the method to query upload status at least for a simple case of uploading in chunks. Some debugging has to be done in the Node library to understand what is failing here.

See here for the test case to add: https://github.com/googleapis/conformance-tests/blob/main/storage/v1/retry_tests.json#L257

@tritone tritone added priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like. labels May 8, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label May 8, 2023
@simllll
Copy link

simllll commented Apr 18, 2024

I think I ran into something simliar:

RangeError: The offset is lower than the number of bytes written. The server has 183762944 bytes and while 184465013 bytes has been uploaded - thus 702069 bytes are missing. Stopping as this could result in data loss. Initiate a new upload to continue.
    at Upload.startUploading (/home/simon/Dev/hokify/hokify/node_modules/.pnpm/@[email protected]/node_modules/@google-cloud/storage/build/cjs/src/resumable-upload.js:463:32)
    at Upload.continueUploading (/home/simon/Dev/hokify/hokify/node_modules/.pnpm/@[email protected]/node_modules/@google-cloud/storage/build/cjs/src/resumable-upload.js:450:21)
    at processTicksAndRejections (node:internal/process/task_queues:95:5) RangeError

hard to reproduce, but it happens quite a lot lately... any idea what I could try to fix this?

@iamstarkov
Copy link

we experienced it during the production workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants