Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for labels #466

Open
jyoo-mad opened this issue Nov 15, 2024 · 0 comments
Open

Support for labels #466

jyoo-mad opened this issue Nov 15, 2024 · 0 comments
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jyoo-mad
Copy link

Is your feature request related to a problem? Please describe.
As of 1.9, there is currently no support for labels

Describe the solution you'd like
I don't know the level of client-side validation the maintainers would like, but it could be as simple as adding the optional property to the GenerateContentRequest type as a Record<string, string> and passing it through here:

const generateContentRequest: GenerateContentRequest = {
contents: request.contents,
systemInstruction: request.systemInstruction,
cachedContent: request.cachedContent,
generationConfig: request.generationConfig ?? generationConfig,
safetySettings: request.safetySettings ?? safetySettings,
tools: request.tools ?? tools,
toolConfig: request.toolConfig ?? toolConfig,
};
You might also allow setting labels at the model-init level and overriding them in the method/request, based on the pattern seen in the code. Whatever the case for implementation, it would be nice to have labels supported by this client.

@jyoo-mad jyoo-mad added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 15, 2024
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the googleapis/nodejs-vertexai API. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant