release-please-action not tagging releases after manifest-pr is merged

[whizzzkid]

TL;DR

Here is an implementation of creating a release PR: https://github.com/ipfs/ipfs-companion/blob/main/.github/workflows/ci.yml#L96-L104

This creates the release PR as expected. On merging this PR, this action runs again, but does nothing. The expectation is not to create a release, because the need is to add more assets to the created release. The release step is separate and is executed when a new tag gets pushed. However release-please-action does not push the tag hence this step never gets executed.

Expected behavior

Since release-please-action is only being used to create a collector PR and not the release itself, the expectation as per the documentation was:

When you're ready to tag a release, simply merge the release PR.

This does not happen if the release step is not happening.

Observed behavior

The release PR merges without creating a release tag, breaking the workflow.

Action YAML

release-pr:
    runs-on: ubuntu-latest
    needs: [test]
    if: github.ref == 'refs/heads/main' && (github.event_name == 'push' || github.event_name == 'workflow_dispatch')
    steps:
      - uses: google-github-actions/[email protected]
        with:
          command: manifest-pr
          changelog-notes-type: github

Log output

No response

Additional information

No response

[chingor13]

If you want it to tag, use the manifest command. The manifest-pr command only creates the PR (manifest does PR creation and tagging)

[whizzzkid]

@chingor13 thanks for the quick response, won't that also create a release? Because that's not needed, we just need the tag. Can manifest command be used alongside "skip-github-release": true to create just the tag?