Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest-file input ignored #2470

Open
Jiri-Stary opened this issue Jan 22, 2025 · 0 comments
Open

manifest-file input ignored #2470

Jiri-Stary opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Jiri-Stary
Copy link

Seems to me that manifest-file variable is ignrored

i provide value "release-please-manifest.json" and release please is looking for ".release-please-manifest.json"

Environment details

  • OS:
  • Node.js version:
  • npm version:
  • release-please version:

Run googleapis/release-please-action@v4
Running release-please version: 16.12.0

Steps to reproduce

  1. provide a manifest file name as input

  2. the input variable is ignored

    uses: googleapis/release-please-action@v4
    with:
    release-type: "simple"
    path: ${{ matrix.folder }}
    config-file: release-please-config.json
    manifest-file: release-please-manifest.json
    env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

  3. look in the logs

⚠ file .release-please-manifest.json did not exist

Thanks!

@Jiri-Stary Jiri-Stary added priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants