Skip to content

Commit 3309275

Browse files
authored
chore: Add Clirr exemptions for Protobuf 4.27.4 runtime (#3188)
Clirr is flagging a bunch of 7006 Method Return Type changed errors. The Protoc generated changes are source code compatible and should ignore these errors in our generated code. See [this doc](https://docs.google.com/spreadsheets/d/1qEzUWLougtiqh0ocRaG4e8w12pr89o0T_tQvB6YDStE/edit?pli=1&gid=0#gid=0) for more information. After adding all the Clirr checks exemptions in this PR to the downstream handwritten libraries, we are no longer seeing an Clirr failures.
1 parent 9a432f7 commit 3309275

File tree

1 file changed

+61
-0
lines changed

1 file changed

+61
-0
lines changed

library_generation/owlbot/templates/clirr/clirr-ignored-differences.xml.j2

+61
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,66 @@
1515
<differenceType>7012</differenceType>
1616
<className>{{proto_path}}/*OrBuilder</className>
1717
<method>boolean has*(*)</method>
18+
</difference>
19+
<!-- The following 7006 exemptions are related to Protobuf 4.27.4 upgrade -->
20+
<difference>
21+
<differenceType>7006</differenceType>
22+
<className>{{proto_path}}/**</className>
23+
<method>* getDefaultInstanceForType()</method>
24+
<to>**</to>
25+
</difference>
26+
<difference>
27+
<differenceType>7006</differenceType>
28+
<className>{{proto_path}}/**</className>
29+
<method>* addRepeatedField(*)</method>
30+
<to>**</to>
31+
</difference>
32+
<difference>
33+
<differenceType>7006</differenceType>
34+
<className>{{proto_path}}/**</className>
35+
<method>* clear()</method>
36+
<to>**</to>
37+
</difference>
38+
<difference>
39+
<differenceType>7006</differenceType>
40+
<className>{{proto_path}}/**</className>
41+
<method>* clearField(*)</method>
42+
<to>**</to>
43+
</difference>
44+
<difference>
45+
<differenceType>7006</differenceType>
46+
<className>{{proto_path}}/**</className>
47+
<method>* clearOneof(*)</method>
48+
<to>**</to>
49+
</difference>
50+
<difference>
51+
<differenceType>7006</differenceType>
52+
<className>{{proto_path}}/**</className>
53+
<method>* clone()</method>
54+
<to>**</to>
55+
</difference>
56+
<difference>
57+
<differenceType>7006</differenceType>
58+
<className>{{proto_path}}/**</className>
59+
<method>* mergeUnknownFields(*)</method>
60+
<to>**</to>
61+
</difference>
62+
<difference>
63+
<differenceType>7006</differenceType>
64+
<className>{{proto_path}}/**</className>
65+
<method>* setField(*)</method>
66+
<to>**</to>
67+
</difference>
68+
<difference>
69+
<differenceType>7006</differenceType>
70+
<className>{{proto_path}}/**</className>
71+
<method>* setRepeatedField(*)</method>
72+
<to>**</to>
73+
</difference>
74+
<difference>
75+
<differenceType>7006</differenceType>
76+
<className>{{proto_path}}/**</className>
77+
<method>* setUnknownFields(*)</method>
78+
<to>**</to>
1879
</difference>{% endfor %}
1980
</differences>

0 commit comments

Comments
 (0)