Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Please is not updating WORKSPACE file for _gapic_generator_java_version #2338

Closed
suztomo opened this issue Jan 4, 2024 · 7 comments
Closed

Release Please is not updating WORKSPACE file for _gapic_generator_java_version #2338

suztomo opened this issue Jan 4, 2024 · 7 comments
Assignees
@mpeddada1
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Jan 4, 2024 •
edited
Loading

Release Please does not update WORKSPACE file. A release manager needs to touch the line.

Screenshot 2024-01-04 at 4 57 12 PM
  • Jan 4th f6a71b7 (Deepankar had to manually edit the line)
  • Nov 29th 6cdd786 (Mridula had to manually edit the line)
  • Oct 31st d8d98fc (Joe had to manually edit the line)

Has it ever worked?
@JoeWang1127 JoeWang1127 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 5, 2024
@mpeddada1 mpeddada1 mentioned this issue Jan 5, 2024
Merged
@mpeddada1
Copy link
Contributor

It looks like this file was updated automatically by release-please for 2.28.1-SNAPHOT and 2.28.0

@suztomo
Copy link
Member Author

suztomo commented Jan 5, 2024

@mpeddada1 Nice, encouraging finding. Do you want to take this issue?

@mpeddada1
Copy link
Contributor

@suztomo Happy to give it a try if you're not already working on it! We're experiencing the same issue with the .cloudbuild/ files as well.

@suztomo
Copy link
Member Author

suztomo commented Jan 5, 2024

Thank you

@mpeddada1
Copy link
Contributor

Looking into most recent change since 2.28.0 release: 96338f1

@mpeddada1 mpeddada1 mentioned this issue Jan 9, 2024
Merged
@mpeddada1
Copy link
Contributor

mpeddada1 commented Jan 9, 2024 •
edited
Loading

After #2349 and #2351, release-please is automatically updating the versions in #2350.
Next: verify behavior for snapshot updates.

@mpeddada1
Copy link
Contributor

Release-please is also working for SNAPSHOT updates now (#2398). Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpeddada1 mpeddada1

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suztomo @mpeddada1 @JoeWang1127