Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly builds are failing due to copyright header update #3512

Closed
mpeddada1 opened this issue Jan 3, 2025 · 1 comment · Fixed by #3513
Closed

Nightly builds are failing due to copyright header update #3512

mpeddada1 opened this issue Jan 3, 2025 · 1 comment · Fixed by #3513
Assignees
@blakeli0
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mpeddada1
Copy link
Contributor

mpeddada1 commented Jan 3, 2025 •
edited
Loading

The nightly builds are currently failing with the following error:

Error:  Failures: 
Error:    ComposerTest.gapicClass_addApacheLicense_validInput_succeeds:81 Differences found: 
--- golden
+++ codegen
@@ -1,4 +1,4 @@
 /*
- * Copyright 2024 Google LLC
+ * Copyright 2025 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

Example: #3486

Nightly Failures: #3511
@mpeddada1 mpeddada1 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 3, 2025
@mpeddada1 mpeddada1 changed the title Update copyright header in the golden files to 2025 Nightly builds are failure due to copyright header update Jan 3, 2025
@mpeddada1 mpeddada1 changed the title Nightly builds are failure due to copyright header update Nightly builds are failing due to copyright header update Jan 3, 2025
This was referenced Jan 3, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 6, 2025
Merged
Open
lqiu96 pushed a commit that referenced this issue Feb 20, 2025
@blakeli0 @cloud-java-bot @lqiu96
tests: Update the golden files' copyright to 2025 (#3513)
8ec7757 
Fixes #3512.

The copyright year for GAPIC generated files are automatically [set to
current
year](https://github.com/googleapis/sdk-platform-java/blob/9a65386dfc3146de4f9b36962caae2df0662ac98/gapic-generator-java/src/main/java/com/google/api/generator/gapic/composer/comment/CommentComposer.java#L38).
This creates a problem that all the tests are going to automatically
fail when new year comes. Updating all the golden files' copyright to
2025 in this PR for now.

There are golden test files need to be updated in spring-cloud-gcp as
well since it is dependent on the generator.

In the future, we need to come up with a better strategy that the tests
do not fail automatically, created an issue
#3547 to track the
future enhancement.

---------

Co-authored-by: cloud-java-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakeli0 blakeli0

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Update the golden files' copyright to 2025 googleapis/sdk-platform-java
2 participants
@blakeli0 @mpeddada1