From 5362544edbcad0893f74712cd865d6f6989a1fd3 Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 12 Dec 2024 14:12:20 -0500 Subject: [PATCH 1/5] ci: Allow the nightly source compatibility check to be run manually --- .../downstream_protobuf_compatibility_check_nightly.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml index 8e8de19abb..8738a7f4e5 100644 --- a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml +++ b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml @@ -14,8 +14,11 @@ on: name: Downstream Protobuf Compatibility Check Nightly jobs: downstream-protobuf-test: - # Checks if PR comes from Release-Please branch or if invoked from nightly job - if: github.head_ref == 'release-please--branches--main' || github.event_name == 'schedule' + # This job runs if any of the three conditions match: + # 1. PR is raised from Release-Please (PR comes from branch: release-please--branches-{branch_name}) + # 2. Job is invoked by the nightly job (scheduled event) + # 3. Job is manually invoked via Github UI (workflow_dispatch event) + if: github.head_ref == 'release-please--branches--main' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' runs-on: ubuntu-22.04 strategy: fail-fast: false From 57d91dfcc2b592e1cbf36e4ffb1c2f67337ebfb5 Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 12 Dec 2024 14:22:47 -0500 Subject: [PATCH 2/5] ci: Update the description --- .../downstream_protobuf_compatibility_check_nightly.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml index 8738a7f4e5..ff7cc47af0 100644 --- a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml +++ b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml @@ -6,7 +6,7 @@ on: workflow_dispatch: inputs: protobuf_runtime_versions: - description: 'Comma separated list of Protobuf-Java versions (i.e. "3.25.x","4.x.y")' + description: 'Comma separated list of Protobuf-Java versions (i.e. "3.25.x","4.x.y").\nNote: Surround each version in the list with quotes (\")' required: true schedule: - cron: '0 1 * * *' # Nightly at 1am From 095ae9c6622aee41e86c08858fd73bf3c987594a Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 12 Dec 2024 14:24:14 -0500 Subject: [PATCH 3/5] ci: Update the description --- .../downstream_protobuf_compatibility_check_nightly.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml index ff7cc47af0..00571c6a12 100644 --- a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml +++ b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml @@ -6,7 +6,8 @@ on: workflow_dispatch: inputs: protobuf_runtime_versions: - description: 'Comma separated list of Protobuf-Java versions (i.e. "3.25.x","4.x.y").\nNote: Surround each version in the list with quotes (\")' + description: 'Comma separated list of Protobuf-Java versions (i.e. "3.25.x","4.x.y"). \ + Note: Surround each version in the list with quotes ("")' required: true schedule: - cron: '0 1 * * *' # Nightly at 1am From 31e78aa654e392de9bf8f086518d61336bde0771 Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 12 Dec 2024 14:24:41 -0500 Subject: [PATCH 4/5] ci: Update the description --- .../downstream_protobuf_compatibility_check_nightly.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml index 00571c6a12..686c130baf 100644 --- a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml +++ b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml @@ -6,7 +6,7 @@ on: workflow_dispatch: inputs: protobuf_runtime_versions: - description: 'Comma separated list of Protobuf-Java versions (i.e. "3.25.x","4.x.y"). \ + description: 'Comma separated list of Protobuf-Java versions (i.e. "3.25.x","4.x.y"). Note: Surround each version in the list with quotes ("")' required: true schedule: From a775b008336b847f3fff58c1e54a89f27f1467cc Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Thu, 12 Dec 2024 16:11:21 -0500 Subject: [PATCH 5/5] ci: Update wording to show release-please main branch --- .../downstream_protobuf_compatibility_check_nightly.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml index 686c130baf..a186a8527b 100644 --- a/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml +++ b/.github/workflows/downstream_protobuf_compatibility_check_nightly.yaml @@ -16,7 +16,7 @@ name: Downstream Protobuf Compatibility Check Nightly jobs: downstream-protobuf-test: # This job runs if any of the three conditions match: - # 1. PR is raised from Release-Please (PR comes from branch: release-please--branches-{branch_name}) + # 1. PR is raised from Release-Please (PR comes from branch: release-please--branches-main) # 2. Job is invoked by the nightly job (scheduled event) # 3. Job is manually invoked via Github UI (workflow_dispatch event) if: github.head_ref == 'release-please--branches--main' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'