Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Updated code and dependencies to build on Android Studio 3.2 (pre-androidx) #36

Open
wants to merge 4 commits into
base: arch-training-steps
Choose a base branch
from

Conversation

edwardotis
Copy link

In addition to updating dependencies, the obsolete LifecycleActivity class had to be replaced with AppCompatActivity in the Activity classes. (details below)
Builds, runs in emulator, tests pass.

"Note: Since the Architecture Components are in alpha stage, Fragment and AppCompatActivity classes cannot implement it (because we cannot add a dependency from a stable component to an unstable API). Until Lifecycle is stable, LifecycleActivity andLifecycleFragment classes are provided for convenience. After the Lifecycles project is released, support library fragments and activities will implement the LifecycleOwner interface; LifecycleActivity and LifecycleFragment will be deprecated at that time. Also, see Implementing LifecycleOwner in custom activities and fragments."

https://medium.com/@mladenrakonjac/note-since-the-architecture-components-are-in-alpha-stage-fragment-and-appcompatactivity-classes-b4b055ecd35b

https://medium.com/@mladenrakonjac/note-since-the-architecture-components-are-in-alpha-stage-fragment-and-appcompatactivity-classes-b4b055ecd35b

"Note: Since the Architecture Components are in alpha stage, Fragment and AppCompatActivity classes cannot implement it (because we cannot add a dependency from a stable component to an unstable API). Until Lifecycle is stable, LifecycleActivity andLifecycleFragment classes are provided for convenience. After the Lifecycles project is released, support library fragments and activities will implement the LifecycleOwner interface; LifecycleActivity and LifecycleFragment will be deprecated at that time. Also, see Implementing LifecycleOwner in custom activities and fragments."
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@edwardotis edwardotis changed the title 2019-01-21 Updated code and dependencies to build on Android Studio 3.2+ (pre-androidx) 2019-01-21 Updated code and dependencies to build on Android Studio 3.2 (pre-androidx) Jan 22, 2019
@edwardotis edwardotis changed the title 2019-01-21 Updated code and dependencies to build on Android Studio 3.2 (pre-androidx) Updated code and dependencies to build on Android Studio 3.2 (pre-androidx) Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants