Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set LookupFlags for generated kerning lookups #522

Closed
cmyr opened this issue Oct 27, 2023 · 1 comment
Closed

Correctly set LookupFlags for generated kerning lookups #522

cmyr opened this issue Oct 27, 2023 · 1 comment
Labels
correctness
Milestone
Compile Oswald an...

Comments

@cmyr
Copy link
Member

cmyr commented Oct 27, 2023

ufo2ft kernFeatureWriter sets IgnoreMarks lookupflag by default on its kerning lookups, unless there are kerning pairs between glyphs classified respectively as bases and marks (or marks vs marks); the latter are split into separate lookups where IgnoreMarks lookupflag is not set.

Originally posted by @anthrotype in #517 (comment)
@rsheeter rsheeter mentioned this issue Oct 27, 2023
Merged
@cmyr cmyr added this to the matching GPOS milestone Nov 28, 2023
@cmyr cmyr mentioned this issue Dec 1, 2023
Closed
@rsheeter rsheeter modified the milestones: matching Oswald GPOS (mark/kern), Compile Oswald and compare to fontmake Dec 4, 2023
@cmyr
Copy link
Member Author

cmyr commented Mar 18, 2024

added in #733

@cmyr cmyr closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correctness
Projects
None yet
Milestone
Compile Oswald and compare to fontmake
Development

No branches or pull requests
2 participants
@cmyr @rsheeter