Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steps towards background layers #1781

Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open

Steps towards background layers #1781

wants to merge 61 commits into from

Commits on Nov 27, 2024

  1. First UI stubs for background layers

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    da67da8 View commit details
    Browse the repository at this point in the history

  2. Only show layers list in edit mode

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1d445b7 View commit details
    Browse the repository at this point in the history

  3. Factor out updating of the layers list; ensure it is hidden when not … 

    …at a source
    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    d79b8ed View commit details
    Browse the repository at this point in the history

  4. Add helper method to retrieve (background) layer names for a source

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    119c8cf View commit details
    Browse the repository at this point in the history

  5. Steps towards computing a layer names list

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ff654f9 View commit details
    Browse the repository at this point in the history

  6. Also rebuild scene if the edit layer changes

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a93de44 View commit details
    Browse the repository at this point in the history

  7. Use object for layer list items; switch edit layer on layer list sel … 

    …change
    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1219ea7 View commit details
    Browse the repository at this point in the history

  8. Fix arg name

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ad8a771 View commit details
    Browse the repository at this point in the history

  9. Set editingLayers, this makes it work a little

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    d55e755 View commit details
    Browse the repository at this point in the history

  10. Add missing await

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    73d87a2 View commit details
    Browse the repository at this point in the history

  11. Make changes to editLayerName trigger scene update

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4bfae39 View commit details
    Browse the repository at this point in the history

  12. Use this.sources getter

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9e757aa View commit details
    Browse the repository at this point in the history

  13. Rename method

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    bf5cf04 View commit details
    Browse the repository at this point in the history

  14. Make getBackgroundLayerNamesForSourceIndex use a cache; add and use g… 

    …etSourceIndexForLayerName
    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9b1141b View commit details
    Browse the repository at this point in the history

  15. Rename method

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c31537c View commit details
    Browse the repository at this point in the history

  16. Fix method name

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2f6bc6a View commit details
    Browse the repository at this point in the history

  17. Rename method

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3c186d9 View commit details
    Browse the repository at this point in the history

  18. Move method

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    49bafb2 View commit details
    Browse the repository at this point in the history

  19. Rename method

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    58188c5 View commit details
    Browse the repository at this point in the history

  20. Rename method and property

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    24a11cc View commit details
    Browse the repository at this point in the history

  21. Fix accordeon item title; add todo comment

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    72781bd View commit details
    Browse the repository at this point in the history

  22. Disable bg layers feature for now

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    dbb5d20 View commit details
    Browse the repository at this point in the history

  23. Rename argument

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    44a83c6 View commit details
    Browse the repository at this point in the history

  24. Methods to find source index from location

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0e7e5cd View commit details
    Browse the repository at this point in the history

  25. Use location string to idintify bg glyphs and edit glyphs

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    40b5f3c View commit details
    Browse the repository at this point in the history

  26. Fix 'view all bg layers'

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1bb6523 View commit details
    Browse the repository at this point in the history

  27. Remove unused method

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    cac78ef View commit details
    Browse the repository at this point in the history

  28. Add comment

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    d174462 View commit details
    Browse the repository at this point in the history

  29. Rename method and change logic so it also returns the 'default' layer

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1572bca View commit details
    Browse the repository at this point in the history

  30. No need to add the foreground layer separately, just fill in a name

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    8eb72d9 View commit details
    Browse the repository at this point in the history

  31. backgroundLayersList -> sourceLayersList

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    f24ce3e View commit details
    Browse the repository at this point in the history

  32. Move background layers to scene settings

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e3f9ae2 View commit details
    Browse the repository at this point in the history

  33. Move editingLayers to scene settings

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9bbfaaf View commit details
    Browse the repository at this point in the history

  34. Take locationBase into account when making loc string

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    56a36aa View commit details
    Browse the repository at this point in the history

  35. Keep locationString as part of source item

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    b5a9a7c View commit details
    Browse the repository at this point in the history

  36. We have a var for layerName

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    39687cf View commit details
    Browse the repository at this point in the history

  37. Subscribe to bg layer / editing layer changes, and update list items

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c69a562 View commit details
    Browse the repository at this point in the history

  38. Make the updating go via the editingLayers scene settings field inste… 

    …ad of via the items
    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0a9eb3b View commit details
    Browse the repository at this point in the history

  39. Delete unused method

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1252631 View commit details
    Browse the repository at this point in the history

  40. Make the updating go via the editingLayers scene settings field inste… 

    …ad of via the items
    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c238f37 View commit details
    Browse the repository at this point in the history

  41. Rename property

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    997d6df View commit details
    Browse the repository at this point in the history

  42. Rename variable

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    b35d2ff View commit details
    Browse the repository at this point in the history

  43. Make getSourceLayerNamesForSourceIndex return list of objects

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ddfd591 View commit details
    Browse the repository at this point in the history

  44. Don't mess with the editing layers if we're editing a bg layer

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    8e87372 View commit details
    Browse the repository at this point in the history

  45. Fill in proper loc string when selecting bg layer

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    09a6efe View commit details
    Browse the repository at this point in the history

  46. Select the first item when switching sources

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c423a09 View commit details
    Browse the repository at this point in the history

  47. Rename methods to be more precise

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a7c9643 View commit details
    Browse the repository at this point in the history

  48. Slight simplification/optimization

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1746b61 View commit details
    Browse the repository at this point in the history

  49. Keep edit layer info with undo record

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    dcb8e51 View commit details
    Browse the repository at this point in the history

  50. Select the right source layer item

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    283b967 View commit details
    Browse the repository at this point in the history

  51. Make edit layers persistent through in the URL fragment

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    86b6bcb View commit details
    Browse the repository at this point in the history

  52. Don't do things when there's no items

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    237c755 View commit details
    Browse the repository at this point in the history

  53. Put 'select glyph/source/layer' menu items under submenu

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    bad896d View commit details
    Browse the repository at this point in the history

  54. Make --include-wip take an argument for further filtering

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    bb266d7 View commit details
    Browse the repository at this point in the history

  55. Add new UI strings

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    941f032 View commit details
    Browse the repository at this point in the history

  56. Add submenu title

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1459cbe View commit details
    Browse the repository at this point in the history

  57. Plug in select-next-source-layer functionality

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a071c4f View commit details
    Browse the repository at this point in the history

  58. Use altKey instead of shiftKey: shift-command-arrow key shifts by 100… 

    … units, for better or for worse
    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9abce6c View commit details
    Browse the repository at this point in the history

  59. Don't crash on on-of-bounds point index

    @justvanrossum
    justvanrossum committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1878981 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2024

  1. Merge French and Japanese additions

    @justvanrossum
    justvanrossum committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    38e80e7 View commit details
    Browse the repository at this point in the history

  2. Merge main, resolving conflicts

    @justvanrossum
    justvanrossum committed Nov 30, 2024
    Configuration menu
    Copy the full SHA
    631a3c5 View commit details
    Browse the repository at this point in the history