From bd5d626e1553faba02697bef02ce7695b4faf4d0 Mon Sep 17 00:00:00 2001 From: max Date: Mon, 15 Jul 2024 09:52:54 +0200 Subject: [PATCH 1/3] fix: Wrong escape sequences --- Lib/gftools/builder/operations/autohintOTF.py | 2 +- Lib/gftools/push/items.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/gftools/builder/operations/autohintOTF.py b/Lib/gftools/builder/operations/autohintOTF.py index aa6443f14..07cfd0943 100644 --- a/Lib/gftools/builder/operations/autohintOTF.py +++ b/Lib/gftools/builder/operations/autohintOTF.py @@ -3,4 +3,4 @@ class AutohintOTF(OperationBase): description = "Run otfautohint" - rule = "otfautohint $args -o $out $in \|\| otfautohint $args -o $out $in --no-zones-stems" + rule = "otfautohint $args -o $out $in \\|\\| otfautohint $args -o $out $in --no-zones-stems" diff --git a/Lib/gftools/push/items.py b/Lib/gftools/push/items.py index dd941c230..c0f54a9aa 100644 --- a/Lib/gftools/push/items.py +++ b/Lib/gftools/push/items.py @@ -212,7 +212,7 @@ def parse_html(string: str): if not string: return None text = BeautifulSoup(string, features="lxml").text - return re.sub("\s+", " ", text).strip() + return re.sub(r"\s+", " ", text).strip() @dataclass From 7e3d72fa283dfc56a8814001a474aced3e8d1f80 Mon Sep 17 00:00:00 2001 From: max Date: Tue, 16 Jul 2024 14:11:20 +0200 Subject: [PATCH 2/3] fix: Make sure that the filepath shell arguments are enclosed in quotes --- Lib/gftools/builder/operations/autohintOTF.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/gftools/builder/operations/autohintOTF.py b/Lib/gftools/builder/operations/autohintOTF.py index 07cfd0943..89f02851c 100644 --- a/Lib/gftools/builder/operations/autohintOTF.py +++ b/Lib/gftools/builder/operations/autohintOTF.py @@ -3,4 +3,4 @@ class AutohintOTF(OperationBase): description = "Run otfautohint" - rule = "otfautohint $args -o $out $in \\|\\| otfautohint $args -o $out $in --no-zones-stems" + rule = "otfautohint $args -o \"$out\" \"$in\" \\|\\| otfautohint $args -o \"$out\" \"$in\" --no-zones-stems" From 47156331f3d240762f5bae7fe2e15eaef6a09442 Mon Sep 17 00:00:00 2001 From: max Date: Tue, 16 Jul 2024 14:55:11 +0200 Subject: [PATCH 3/3] style: Codestyle linting --- Lib/gftools/builder/operations/autohintOTF.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/gftools/builder/operations/autohintOTF.py b/Lib/gftools/builder/operations/autohintOTF.py index 89f02851c..2c68e93a9 100644 --- a/Lib/gftools/builder/operations/autohintOTF.py +++ b/Lib/gftools/builder/operations/autohintOTF.py @@ -3,4 +3,4 @@ class AutohintOTF(OperationBase): description = "Run otfautohint" - rule = "otfautohint $args -o \"$out\" \"$in\" \\|\\| otfautohint $args -o \"$out\" \"$in\" --no-zones-stems" + rule = 'otfautohint $args -o "$out" "$in" \\|\\| otfautohint $args -o "$out" "$in" --no-zones-stems'