Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completeness is wasteful #673

Closed
simoncozens opened this issue Mar 25, 2021 · 5 comments
Closed

Completeness is wasteful #673

simoncozens opened this issue Mar 25, 2021 · 5 comments

Comments

@simoncozens
Copy link
Collaborator

In the common case of using glyphsLib to convert to UFO as part of the fontmake pipeline, all of this code is unnecessary:

    self.to_ufo_background_image(ufo_glyph, layer)
    self.to_ufo_guidelines(ufo_glyph, layer)
    self.to_ufo_glyph_background(ufo_glyph, layer)
    self.to_ufo_annotations(ufo_glyph, layer)

Converting any non-master, non-brace layers is also wasteful.

@khaledhosny
Copy link
Collaborator

Not only wasteful, Glyphs files might have some garbage there (e.g. layers with duplicate names) that will not be used for anything but will break the build anyway.

@simoncozens simoncozens mentioned this issue Mar 28, 2021
@moyogo
Copy link
Collaborator

moyogo commented Mar 28, 2021

Color layers can have the same name if they have the same color. #573

@simoncozens
Copy link
Collaborator Author

Incidentally the performance impact of doing less is pretty minimal in the grand scheme of things: https://daltonmaag.github.io/pipeline-perf-tracker/results/

@madig
Copy link
Collaborator

madig commented Mar 31, 2021

Profile of fontmake when compiling Noto Sans to a VF from a .glyphs file:

image

A lot of time is wasted on 1. writing intermediate UFOs to disk because MutatorMath needs that 2. parsing the file.

@simoncozens
Copy link
Collaborator Author

Use the new parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants