Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "disabled" glyph classes #763

Open
psb1558 opened this issue Jan 9, 2022 · 5 comments
Open

Support "disabled" glyph classes #763

psb1558 opened this issue Jan 9, 2022 · 5 comments

Comments

@psb1558
Copy link

psb1558 commented Jan 9, 2022

For example, features.fea in all generated UFOs has "uni0305" in "@MarkClass1" but "overlinecomb" elsewhere in features.fea and all other files.

To reproduce, run glyphs2ufo on this file (Junicode Italic).

Is this a bug, or is there something odd about this file?

@khaledhosny
Copy link
Collaborator

These classes are defined like this in the Glyphs file, and are not generated by glyphs2ufo:
image

@psb1558
Copy link
Author

psb1558 commented Jan 9, 2022

Oh, heavens, I never even looked at those because I had them disabled and assumed that glyphsLib would therefore ignore them. I will close this (with more than a little embarrassment).

But isn't it odd that glyphsLib doesn't respect the "disabled" flags in the Glyphs file? Makes it a little tricky to generate fonts while a project is in progress.

@psb1558 psb1558 closed this as completed Jan 9, 2022
@khaledhosny
Copy link
Collaborator

I think #761 should fix this.

@psb1558
Copy link
Author

psb1558 commented Jan 10, 2022

Looks good.

@khaledhosny khaledhosny reopened this Jan 11, 2022
@khaledhosny
Copy link
Collaborator

We need to fix handling of disabled classes, #761 does not actually handle it.

@khaledhosny khaledhosny changed the title glyphs2ufo substituting production names in mark classes but not elsewhere Support "disabled" glyph classes Jan 11, 2022
khaledhosny added a commit that referenced this issue Aug 29, 2024
schriftgestalt pushed a commit that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants