Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated "toml" library #452

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

CyberTailor
Copy link
Contributor

Fixes #451

@google-cla
Copy link

google-cla bot commented May 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rsheeter
Copy link
Collaborator

Ty for the PR. Apologies for the inconvenience but would you be willing to sign the CLA? - we can't accept otherwise.

@CyberTailor
Copy link
Contributor Author

I've signed it

@CyberTailor
Copy link
Contributor Author

@anthrotype
Copy link
Member

thanks. Can you please run black auto-formatter so that the lint CI job passes as well?

https://github.com/googlefonts/nanoemoji/actions/runs/5036873831/jobs/9036557954?pr=452

@anthrotype
Copy link
Member

@CyberTailor oh, I see the lint job failing has nothing to do with your specific PR, it's just a new black version that changed the way it wants to format things (and we keep deps un-pinned so this can happen /cc @rsheeter). You can ignore this, we can fix up later on after merge.

src/nanoemoji/config.py Outdated Show resolved Hide resolved
src/nanoemoji/config.py Outdated Show resolved Hide resolved
src/nanoemoji/config.py Outdated Show resolved Hide resolved
@anthrotype
Copy link
Member

python 3.7 complains importlib.resources has no attribute "files"

https://github.com/googlefonts/nanoemoji/actions/runs/5044764986/jobs/9048275533?pr=452#step:5:71

do you mind not reverting that line change for now use the old deprecated method, we may want to drop 3.7 support at some point but maybe not immediately in this PR.

@anthrotype
Copy link
Member

I see that files method is 3.9+ only, we do want to support 3.8 for a bit longer. I would rather we keep the deprecation warning (or if we really don't want to see that, only use the newer API for 3.9+)

@CyberTailor
Copy link
Contributor Author

do you mind not reverting that line change for now use the old deprecated method, we may want to drop 3.7 support at some point but maybe not immediately in this PR.

Reverted.

@anthrotype anthrotype merged commit a205dfd into googlefonts:main May 22, 2023
@anthrotype
Copy link
Member

thank you for the contribution and for the patience :)

anthrotype added a commit that referenced this pull request Aug 4, 2023
This reverts commit a205dfd, reversing
changes made to 5e6281b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from deprecated toml library
3 participants