Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region flags #349

Open
basaundi opened this issue May 17, 2021 · 3 comments
Open

Region flags #349

basaundi opened this issue May 17, 2021 · 3 comments

Comments

@basaundi
Copy link

What is the best way to have the missing region flags included?
In particular, I am interested in including the Spanish region flags.

Some years ago I made a PR to behdad/region-flags which was then moved to fonttools/region-flags#34.
I made this PR in hope that, with time, these would end up being included in noto-emoi.

However this repo seems to not be mantained and the process seems to have changed (?)

I want to know if it will be possible to include the Spanish region flags and what would that take.

Thank you.

@ChiefMikeK
Copy link

Maybe it's time to create a new font family / repo for this ie.

? /googlefonts/noto-flags/noto-flag??.otf

  • noto-flagsES.otf
  • noto-flagsCA.otf
  • noto-flagsUS.off
  • noto-flagsMX.off
  • ect. etc.

Also wikipedia has most if not all of the *.svg files available as source!

@basaundi
Copy link
Author

basaundi commented May 20, 2021

My PR to fonttools/region-flags was accepted few minutes after I posted this issue.

The flags are now in the fonttools repo. The current flags at googlefonts/noto-emoji/tree/main/third_party/region-flags were downloaded from google/region-flags, a 4-year-old fork of fonttools/region-flags.

The technical solution would be to bump the version. Would a PR of this nature be accepted?
Do we need to update google/region-flags first?
I opened an issue there. google/region-flags/issues/8

BTW, these flags come from wikipedia.

@SaveTheRbtz
Copy link
Contributor

SaveTheRbtz commented Apr 4, 2022

Hi, one of the region-flags devs here. JFYI: Trying to bump flags from the region-flags upstream: #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants