Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Vietnamese #6

Open
crystaltype opened this issue Nov 13, 2017 · 2 comments
Open

Improving Vietnamese #6

crystaltype opened this issue Nov 13, 2017 · 2 comments

Comments

@crystaltype
Copy link

only some suggestions:

  • Stacked diacritics such as Circumflex+acute/grave in uppercase characters should have the same weight as the stem weight, especially in thin/light/normal weight (they’re thinner as of now). And they should not be scaled vertically.
  • I think the single acute/grave + character combination, the accents are a little too big. If it’s placed near a stacked diacritics combination such as in this word: “Vẫn còn”, it would not look balanced.
  • The breve could be more narrowed to avoid confusion with macron, especially in small sizes. Actually Vietnamese doesn’t know about macron but still they would view it simply as a “-” (at small sizes), so it would affect their natural reading flow.

These suggestions are for both Nunito and Nunito Sans.

screen shot 11-10-17 at 06 17 pm

I'm willing to help contribute the changes directly, by sending you a 'vietnamese only' glyphapp file for you to review and integrate.

Or, you can make changes and then push your work to master and I will give further feedback :)

@alexeiva
Copy link

alexeiva commented Nov 20, 2017

Hey Nhung, thank you for the suggestion. For Nunito Sans could you make a fork from Jacque's repo and apply these changes there: https://github.com/Fonthausen/NunitoSans

For Nunito you can make a fork from this repo.

@crystaltype
Copy link
Author

Thanks Alexei,

Sure, I'll do it like you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants