Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do cPy 3.11.x interpreter startup and runtime performance improvements impact fontmake-based font compile times? #26

Open
chrissimpkins opened this issue Jun 10, 2022 · 12 comments
Labels

Comments

@chrissimpkins
Copy link
Member

chrissimpkins commented Jun 10, 2022

cPython 3.11 betas are documented to be ~25% faster than cPy 3.10 with improvements in interpreter startup and run times.

Do the cPy 3.11 changes improve font compile times with the fontmake-based Python compiler pipeline?

@madig
Copy link

madig commented Jun 13, 2022

"Failed to build compreffor pyclipper"

Seems like Cython has problems with 3.11. Not sure how easily this is fixed.

@anthrotype
Copy link
Member

what's the error? maybe file a bug

@madig
Copy link

madig commented Jun 13, 2022

It's this one: aio-libs/aiohttp#6600

Haven't looked into if this could be fixed by a version bump somewhere.

@anthrotype
Copy link
Member

compreffor issue with cpython 3.11 should now be fixed with https://pypi.org/project/compreffor/0.5.2
please try again

@anthrotype
Copy link
Member

also fixed the same issue in pyclipper https://pypi.org/project/pyclipper/1.3.0.post3/

@madig
Copy link

madig commented Jun 13, 2022

Installs now, kthx.

@madig
Copy link

madig commented Jun 13, 2022

Results for the cut-instances branch, which excludes Telugu:

Benchmark 1: make -j (CPython 3.8.10)
  Time (mean ± σ):     483.297 s ±  0.042 s    [User: 3020.954 s, System: 18.076 s]
  Range (min … max):   483.267 s … 483.327 s    2 runs

Benchmark 1: cd ../googlesans-cp311 ; make -j (CPython 3.11b3)
  Time (mean ± σ):     404.991 s ±  1.003 s    [User: 2513.287 s, System: 12.531 s]
  Range (min … max):   404.281 s … 405.700 s    2 runs

Benchmark 1: cd ../googlesans-pypy ; make -j (Pypy 7.3.9)
  Time (mean ± σ):     345.172 s ±  1.359 s    [User: 1673.498 s, System: 17.142 s]
  Range (min … max):   344.211 s … 346.133 s    2 runs

So, 3.11b3 is 16% faster than 3.8 and Pypy is 29% faster than 3.8. Note: I upgarded all deps to their newest version for 3.11 but saw no obvious unfairness.

@behdad
Copy link

behdad commented Jun 14, 2022

Beauty.

@behdad
Copy link

behdad commented Jun 14, 2022

Maybe report back upstream. 👏

@chrissimpkins
Copy link
Member Author

@madig The results in #26 (comment) are from GS compiles?

@chrissimpkins
Copy link
Member Author

How is memory use in the cPy 3.11 vs. cPy < 3.11 comparison? Any significant changes there?

Related mem issues with pypy3 compile time performance improvements documented in #28

@madig
Copy link

madig commented Jul 13, 2022

@madig The results in #26 (comment) are from GS compiles?

Yes, from before Telugu landed.

I have not measured memory usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants