Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need requirements.txt #283

Closed
tphinney opened this issue Apr 9, 2022 · 2 comments
Closed

Need requirements.txt #283

tphinney opened this issue Apr 9, 2022 · 2 comments
Assignees
Labels
Google Requirement Required for Google Fonts submission/onboarding Meta not in font Dev related, not internal to font file (e.g. Python script needed, charset definition problem, etc.)

Comments

@tphinney
Copy link
Collaborator

tphinney commented Apr 9, 2022

Need a file like this at the root level of the repository:
https://github.com/googlefonts/googlefonts-project-template/blob/main/requirements.txt

@tphinney tphinney added the Meta not in font Dev related, not internal to font file (e.g. Python script needed, charset definition problem, etc.) label Apr 9, 2022
@tphinney tphinney self-assigned this Apr 9, 2022
@tphinney tphinney moved this to To do in Science Gothic VF Jun 10, 2024
@tphinney tphinney added the Google Requirement Required for Google Fonts submission/onboarding label Oct 23, 2024
kateliev added a commit that referenced this issue Nov 18, 2024
- Add necessary files;
@kateliev
Copy link
Member

kateliev commented Nov 18, 2024

@tphinney added the necessary file based on our project requirements...

The file I just pushed is in it's "classic" (txt) form containing all the tools+versions for building the font

fontbakery>=0.12.6
fontmake>=3.9.0
gftools[qa]>=0.9.58
sh>=2.0.6
statmake>=0.6.0

BUT your link is pointing to a requirements.txt file that is supposedly auto-updated (and supported) by a whole build/test chain, that is given as part of a whole google-fonts-new-submission-template. This is not bad, just raises a question: Should we use the provided template and restructure our whole project, or keep it as it is now? Their requirements.txt is actually pointing to a requirements.in file that is used by their make build process and is generated by make update command. All utilizing make in conjunction with the respected makefile.

@tphinney tphinney moved this from To do to In progress in Science Gothic VF Nov 19, 2024
@tphinney
Copy link
Collaborator Author

I think the rest of that is covered in #281; see discussion there.

@github-project-automation github-project-automation bot moved this from In progress to Done in Science Gothic VF Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google Requirement Required for Google Fonts submission/onboarding Meta not in font Dev related, not internal to font file (e.g. Python script needed, charset definition problem, etc.)
Projects
Status: Done
Development

No branches or pull requests

2 participants