Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add African Pri glyph coverage #302

Closed
tphinney opened this issue Oct 24, 2023 · 8 comments
Closed

Add African Pri glyph coverage #302

tphinney opened this issue Oct 24, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request new glyphs - Medium New glyphs for Medium master new glyphs - others Designing glyphs for additional masters

Comments

@tphinney
Copy link
Collaborator

tphinney commented Oct 24, 2023

(UPDATE: Still a moving target when this was written, check for latest data!)

There are about 32 glyphs defined for this. About 15 are already in the current builds of Science Gothic.

Then there are about 8 that need composite glyphs defined (+4 for small caps)

And about 8 (12 including small caps) that need custom new glyphs made, because they are letters with hooks, which are attached rather than floating.

googlefonts/glyphsets#137

https://docs.google.com/spreadsheets/d/10MQCuYIGBDPqYFr1WEYWvu9Tshk5ASsr25NGVcJksYs/edit#gid=0

@tphinney tphinney added enhancement New feature or request new glyphs - Medium New glyphs for Medium master new glyphs - others Designing glyphs for additional masters labels Oct 24, 2023
@chrissimpkins
Copy link
Member

See the latest updates to the glyph set based on feedback from Neil and Denis. googlefonts/glyphsets@772fe9c

@tphinney
Copy link
Collaborator Author

tphinney commented Nov 3, 2023

@chrissimpkins hmmm. Funny that it has "0x1e63 LATIN SMALL LETTER S WITH DOT BELOW" but not the matching capital letter. I am going to assume that is an error until/unless somebody tells me differently.

@tphinney
Copy link
Collaborator Author

Need to recheck against the latest version of the data

kateliev added a commit that referenced this issue Nov 28, 2023
- Add necessary glyphs to font set: googlefonts/glyphsets@772fe9c
- New glyphs (3): "Eopen","Oopen","oopen";
- New auto glyphs (8): "Macute","Ndotaccent","Ngrave","Sdotbelow","macute","ndotaccent","ngrave","sdotbelow"
kateliev added a commit that referenced this issue Nov 29, 2023
"bhook","dhook","eopen","khook","nhookleft","yhook"
kateliev added a commit that referenced this issue Nov 30, 2023
"Bhook","Dhook","Nhookleft","macute.sc","ndotaccent.sc","ngrave.sc","sdotbelow.sc","eopen.sc","nhookleft.sc","oopen.sc"
kateliev added a commit that referenced this issue Dec 1, 2023
"Khook","Yhook","bhook.sc","dhook.sc"
kateliev added a commit that referenced this issue Dec 4, 2023
kateliev added a commit that referenced this issue Dec 4, 2023
"khook.sc","yhook.s"

Issue #302: Add African Pri glyph coverage
- Set kerning and metric groups;
kateliev added a commit that referenced this issue Dec 5, 2023
- metrics and kern adjustments
kateliev added a commit that referenced this issue Dec 5, 2023
- metrics and kern adjustments
kateliev added a commit that referenced this issue Dec 6, 2023
Issue #288: Add .loclBGR to existing Cyrillic set
- metrics and kern adjustments;
- OT features;
- Unicode fix;
kateliev added a commit that referenced this issue Dec 6, 2023
Issue #288: Add .loclBGR to existing Cyrillic set
- metrics and kern adjustments;
kateliev added a commit that referenced this issue Dec 8, 2023
Issue #302: Add African Pri glyph coverage
- Kerning
- Glyph tweaks
@kateliev
Copy link
Member

kateliev commented Dec 8, 2023

These are now done!

BUT discussing #309 it just came to me! Currently we are using uniXXXX font naming standard through the typeface, but for the newly generated African glyphs i used friendly names (bit mislead by the google glyphset docs).

image

What shall we do about it:
a) keep it as it is;
b) change it to uniXXXX;

@tphinney
Copy link
Collaborator Author

tphinney commented Dec 8, 2023

Aha. Yeah, so... Glyphs App has a function where one can use Glyphs/friendly names and those get automatically mapped to “proper” glyph names at export time.

So you might think this is bad, these names are not in AGL so they ought to be uniXXXX names in the actual font.

But honestly the cases where glyph names even matter are super corner cases. Mostly for PDF generated from a print stream without a separate font available, and the font is CFF. I am making some inquiries about this, see how much it matters or Google cares about it, in OT-TTF.

@tphinney
Copy link
Collaborator Author

tphinney commented Dec 8, 2023

Yeah, the glyph names in OT-TTF don’t even survive on the Google server. They drop glyph names entirely for the version they serve up dynamically!

How much work to change them?

Dave does not think it matters. Let’s see if FontBakery cares. If not, we will leave it as is.

So do a fresh TTF build so we can test this and other things?

@tphinney
Copy link
Collaborator Author

Apparently FontBakery does care. Not sure if it is a WARN or a FAIL. However, I see no warning on this at all from Fontbakery on a font exported directly from FontLab 8.3.

Let’s do a Fontmake based build and also make sure we have the latest Fontbakery, and see what we get.

kateliev added a commit that referenced this issue Dec 13, 2023
- Uc Hooks kern adjustments;
@tphinney
Copy link
Collaborator Author

Well, I did check with the latest Fontbakery and it seems not to object. I wonder if this might be because the TTF export is dropping glyph names? But in any case we seem to be OK.

@tphinney tphinney moved this to Done in Science Gothic VF Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new glyphs - Medium New glyphs for Medium master new glyphs - others Designing glyphs for additional masters
Projects
Status: Done
Development

No branches or pull requests

3 participants