Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add © symbol back into copyright notice #355

Open
tphinney opened this issue Oct 24, 2024 · 4 comments
Open

Add © symbol back into copyright notice #355

tphinney opened this issue Oct 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@tphinney
Copy link
Collaborator

tphinney commented Oct 24, 2024

Seeing as Google has just officially changed its mind on this, we can put the © symbol back into the copyright notice.

So instead of Copyright 2024 we can Copyright © 2024 (or even drop the word Copyright entirely)

@tphinney tphinney added the enhancement New feature or request label Oct 24, 2024
@tphinney tphinney self-assigned this Oct 24, 2024
kateliev added a commit that referenced this issue Nov 18, 2024
- Added `Copyright © 2024` to Font's copyright notice.
@kateliev
Copy link
Member

Done added Copyright © 2024 to fonts copyright notice (in .vfc)

@kateliev
Copy link
Member

kateliev commented Dec 2, 2024

@tphinney this was done, BUT was actually not OK by G standards. Fontbakery is still complaining and generating 2 FAILS:


Are there non-ASCII characters in ASCII-only NAME table entries?
Check ID: FontBakeryCheck:com.google.fonts/check/name/ascii_only_entries
The OpenType spec requires ASCII for the POSTSCRIPT_NAME (nameID 6).

For COPYRIGHT_NOTICE (nameID 0) ASCII is required because that string should be the same in CFF fonts which also have this requirement in the OpenType spec.

Note: A common place where we find non-ASCII strings is on name table entries with NameID > 18, which are expressly for localising the ASCII-only IDs into Hindi / Arabic / etc.

Original proposal: legacy:check/074
See also: fonttools/fontbakery#1663
🔥 ScienceGothic[YOPQ,slnt,wdth,wght].ttf
🔥 FAIL
Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright © 2024 The Science Gothic Project Authors (https://github.com/googlefonts/science-gothic/blob/main/AUTHORS.txt)''

[code: bad-string]
🔥 FAIL
There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries.

[code: non-ascii-strings]


Substitute copyright, registered and trademark symbols in name table entries.
Check ID: FontBakeryCheck:com.google.fonts/check/name/unwanted_chars
We don't want non-ASCII characters in name table entries; in particular, copyright, trademark and registered symbols should be written using their ASCII counterparts: e.g. (c), (tm) and (r) respectively.

Original proposal: legacy:check/019
🔥 ScienceGothic[YOPQ,slnt,wdth,wght].ttf
🔥 FAIL
NAMEID #0 contains symbols that should be replaced by '(c)'.

[code: unwanted-chars]


So IMHO the appropriate action here is to remove the non-canonical symbol from all the copyright notices. Keeping it is just pointless.

@kateliev kateliev reopened this Dec 2, 2024
@kateliev kateliev self-assigned this Dec 2, 2024
@kateliev kateliev added the FontBakery Fail or Error from FontBakery tests label Dec 2, 2024
@kateliev kateliev removed the enhancement New feature or request label Dec 2, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Science Gothic VF Dec 2, 2024
@tphinney tphinney reopened this Dec 3, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Science Gothic VF Dec 3, 2024
@tphinney
Copy link
Collaborator Author

tphinney commented Dec 3, 2024

@kateliev are you sure you are using the latest Fontbakery?

You can see that it either has been changed, or is in the process of being changed, here: fonttools/fontbakery#2854

@kateliev
Copy link
Member

kateliev commented Dec 3, 2024

@kateliev are you sure you are using the latest Fontbakery?

Yes updated it especially for our latest build.

Concerning the use of the symbol , IMHO this seems far from important this is why I will put it in the freeze box for now so that it does not mess up builds/reports.

@kateliev kateliev moved this from In progress to Icebox in Science Gothic VF Dec 3, 2024
@kateliev kateliev added enhancement New feature or request and removed FontBakery Fail or Error from FontBakery tests labels Dec 3, 2024
@tphinney tphinney moved this from Icebox to To do in Science Gothic VF Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants