-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add © symbol back into copyright notice #355
Comments
- Added `Copyright © 2024` to Font's copyright notice.
Done added |
@tphinney this was done, BUT was actually not OK by G standards. Fontbakery is still complaining and generating 2 FAILS: Are there non-ASCII characters in ASCII-only NAME table entries? For COPYRIGHT_NOTICE (nameID 0) ASCII is required because that string should be the same in CFF fonts which also have this requirement in the OpenType spec. Note: A common place where we find non-ASCII strings is on name table entries with NameID > 18, which are expressly for localising the ASCII-only IDs into Hindi / Arabic / etc. Original proposal: legacy:check/074 [code: bad-string] [code: non-ascii-strings] Substitute copyright, registered and trademark symbols in name table entries. Original proposal: legacy:check/019 [code: unwanted-chars] So IMHO the appropriate action here is to remove the non-canonical symbol from all the copyright notices. Keeping it is just pointless. |
@kateliev are you sure you are using the latest Fontbakery? You can see that it either has been changed, or is in the process of being changed, here: fonttools/fontbakery#2854 |
Yes updated it especially for our latest build. Concerning the use of the symbol , IMHO this seems far from important this is why I will put it in the freeze box for now so that it does not mess up builds/reports. |
Seeing as Google has just officially changed its mind on this, we can put the © symbol back into the copyright notice.
So instead of Copyright 2024 we can Copyright © 2024 (or even drop the word Copyright entirely)
The text was updated successfully, but these errors were encountered: